All of lore.kernel.org
 help / color / mirror / Atom feed
From: sam@ravnborg.org
To: linux-kernel@vger.kernel.org
Cc: Roman Zippel <zippel@linux-m68k.org>, Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH] kconfig: correct oldconfig for unset choice options
Date: Sat, 29 Jul 2006 09:19:39 +0200	[thread overview]
Message-ID: <11541575811046-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <11541575811787-git-send-email-sam@ravnborg.org>

From: Roman Zippel <zippel@linux-m68k.org>

oldconfig currently ignores unset choice options and doesn't ask for them.
Correct the SYMBOL_DEF_USER flag of the choice symbol to be only set if
it's set for all values.

Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 scripts/kconfig/confdata.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 2ee48c3..a69d8ac 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -357,7 +357,7 @@ int conf_read(const char *name)
 		for (e = prop->expr; e; e = e->left.expr)
 			if (e->right.sym->visible != no)
 				flags &= e->right.sym->flags;
-		sym->flags |= flags & SYMBOL_DEF_USER;
+		sym->flags &= flags | ~SYMBOL_DEF_USER;
 	}
 
 	sym_change_count += conf_warnings || conf_unsaved;
-- 
1.4.1.rc2.gfc04


  reply	other threads:[~2006-07-29  7:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29  7:15 [PATCH 0/18] kbuild fixes Sam Ravnborg
2006-07-29  7:19 ` [PATCH] kbuild: hardcode value of YACC&LEX for aic7-triple-x sam
2006-07-29  7:19   ` [PATCH] kbuild: version.h and new headers_* targets does not require a kernel config sam
2006-07-29  7:19     ` [PATCH] kbuild: .gitignore utsrelease.h sam
2006-07-29  7:19       ` [PATCH] kbuild: improve error from file2alias sam
2006-07-29  7:19         ` [PATCH] kbuild: fix typo in modpost sam
2006-07-29  7:19           ` [PATCH] kbuild: -fno-stack-protector is not good sam
2006-07-29  7:19             ` sam [this message]
2006-07-29  7:19               ` [PATCH] kconfig: support DOS line endings sam
2006-07-29  7:19                 ` [PATCH] kbuild: consistently decide when to rebuild a target sam
2006-07-29  9:07   ` [PATCH] kbuild: hardcode value of YACC&LEX for aic7-triple-x Alexey Dobriyan
2006-07-30 19:31     ` Sam Ravnborg
2006-08-01 22:00       ` H. Peter Anvin
2006-08-01 22:00     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11541575811046-git-send-email-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.