From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Chuck Ebbert <76306.1226@compuserve.com>,
sfr@canb.auug.org.au,
"William A (Andy) Adamson" <andros@citi.umich.edu>
Cc: Orion Poplawski <orion@cora.nwra.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: fctnl(F_SETSIG) no longer works in 2.6.17, does in 2.6.16.
Date: Mon, 31 Jul 2006 11:23:52 -0700 [thread overview]
Message-ID: <1154370233.8417.11.camel@localhost> (raw)
In-Reply-To: <200607310224_MC3-1-C689-D6DD@compuserve.com>
On Mon, 2006-07-31 at 02:21 -0400, Chuck Ebbert wrote:
> static void lease_release_private_callback(struct file_lock *fl)
> {
> if (!fl->fl_file)
> return;
>
> f_delown(fl->fl_file);
> => fl->fl_file->f_owner.signum = 0;
> }
Why should the lease cleanup code be resetting f_owner.signum? That
looks wrong.
Stephen, I think this line of code predates the CITI changes. Do you
know who added it and why?
Cheers,
Trond
next prev parent reply other threads:[~2006-07-31 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 6:21 fctnl(F_SETSIG) no longer works in 2.6.17, does in 2.6.16 Chuck Ebbert
2006-07-31 18:23 ` Trond Myklebust [this message]
2006-08-01 14:51 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2006-08-08 5:38 Beschorner Daniel
2006-08-08 13:26 ` Trond Myklebust
2006-08-09 8:39 ` Beschorner Daniel
2006-07-27 22:08 Orion Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154370233.8417.11.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=andros@citi.umich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=orion@cora.nwra.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.