From: Patrik Kullman <patrik@yes.nu>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ]
Date: Mon, 31 Jul 2006 19:51:11 +0000 [thread overview]
Message-ID: <1154375471.2813.10.camel@localhost> (raw)
In-Reply-To: <1106245529.15916.12.camel@base.torri.org>
> > return -ENODEV;
> > + } else {
> > + pci_dev_put(pdev);
> > + }
> >
> > /* Check for the a 7101 PMU */
> > - pdev = pci_find_device(PCI_VENDOR_ID_AL, 0x7101, NULL);
> > - if(pdev = NULL)
> > + pdev = pci_get_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M7101, NULL);
>
> What if the previous _and_ this one succeed?
Since the original developer chose to just search for the 1535 and then
overwrite the variable with the 7101 (that will be used), I thought I'd
clear the memory of the first device before assigning the new device to
it.
I guess I shouldn't have.
Will fix.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-07-31 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 18:25 [KJ] Stephen torri
2005-06-03 18:43 ` [KJ] Jesse Millan
2005-10-29 13:09 ` [KJ] Tobias Klauser
2005-11-12 14:55 ` [KJ] Alexey Dobriyan
2006-07-31 6:51 ` [KJ] Henne
2006-07-31 19:51 ` Patrik Kullman [this message]
2006-07-31 19:58 ` [KJ] Patrik Kullman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154375471.2813.10.camel@localhost \
--to=patrik@yes.nu \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.