All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: akpm@linux-foundation.org, benh@kernel.crashing.org,
	linux-kernel@vger.kernel.org, hpa@zytor.com,
	johannes@sipsolutions.net
Subject: Re: [PATCH] Fix get_order()
Date: Tue, 06 Mar 2007 18:51:13 +0000	[thread overview]
Message-ID: <11544.1173207073@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703061040260.5963@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> wrote:

> That seems bogus. "n == 1" should give "0", no?

Sigh.  No.  The comment header says it all:

	/**
	 * roundup_pow_of_two - round the given value up to nearest power of two
	 * @n - parameter
	 *
	 * round the given value up to the nearest power of two
	 * - the result is undefined when n == 0
	 * - this can be used to initialise global variables from constant data
	 */

Ie: round, say, 30 up to 32, not 5.

David

  reply	other threads:[~2007-03-06 18:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-06 17:39 [PATCH] Fix get_order() David Howells
2007-03-06 17:58 ` H. Peter Anvin
2007-03-06 18:21   ` David Howells
2007-03-06 18:41 ` Linus Torvalds
2007-03-06 18:51   ` David Howells [this message]
2007-03-07  3:28 ` Linus Torvalds
2007-03-07 11:43   ` David Howells
2007-03-07 16:02     ` ALIGN via ilog2 without gccisms (Re: [PATCH] Fix get_order()) Oleg Verych
2007-03-07 16:38       ` Linus Torvalds
2007-03-07 17:24         ` Oleg Verych
2007-03-07 18:05           ` Linus Torvalds
2007-03-09 23:13         ` ALIGN " Oleg Verych
2007-03-09 23:15           ` Linus Torvalds
2007-03-10  0:31             ` Oleg Verych
2007-03-10  8:01         ` ALIGN Oleg Verych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11544.1173207073@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=hpa@zytor.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.