All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 0/6] AVR32 update for 2.6.18-rc2-mm1
Date: Tue, 01 Aug 2006 09:47:27 -0700	[thread overview]
Message-ID: <1154450847.5605.21.camel@localhost> (raw)
In-Reply-To: <20060801101210.0548a382@cad-250-152.norway.atmel.com>

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

On Tue, 2006-08-01 at 10:12 +0200, Haavard Skinnemoen wrote:
> On Mon, 31 Jul 2006 11:40:58 -0700
> Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> 
> > On Mon, 2006-07-31 at 17:46 +0200, Haavard Skinnemoen wrote:
> > > On Mon, 31 Jul 2006 15:55:15 +0200
> > > Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:
> > > 
> > > > Anyway, 2.6.18-rc2-mm1 boots successfully on my target with these
> > > > patches, but there's something strange going on with NFS and a few
> > > > other things that I didn't notice on 2.6.18-rc1. I'll investigate
> > > > some more and see if I can figure out what's going on.
> > > 
> > > All forms of write access to the NFS root file system seem to return
> > > -EACCESS. If I leave out git-nfs.patch, the problem goes away, so
> > > I'll try bisecting the NFS git tree tomorrow.
> > 
> > can you check in /proc/self/mountstats what mount options are set on
> > the root file system?
> 
> rw,vers=2,rsize=4096,wsize=4096,acregmin=3,acregmax=60,acdirmin=30,
> acdirmax=60,hard,nolock,proto=udp,timeo=11,retrans=2,sec=null

That 'sec=null' would explain why you are seeing a problem, and the
attached patch ought to fix it.

Cheers,
 Trond

[-- Attachment #2: linux-2.6.18-036-nfs-fix_auth_mount.dif --]
[-- Type: message/rfc822, Size: 931 bytes --]

From: Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: No Subject
Date: Tue, 01 Aug 2006 09:47:17 -0700
Message-ID: <1154450837.5605.20.camel@localhost>

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---

 fs/nfs/super.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 867b5dc..d744f63 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -471,9 +471,10 @@ static int nfs_validate_mount_data(struc
 						data->version);
 				return -EINVAL;
 			}
-			/* Fill in pseudoflavor for mount version < 5 */
-			data->pseudoflavor = RPC_AUTH_UNIX;
 		case 5:
+			/* Set the pseudoflavor */
+			if (!(data->flags & NFS_MOUNT_SECFLAVOUR))
+				data->pseudoflavor = RPC_AUTH_UNIX;
 			memset(data->context, 0, sizeof(data->context));
 	}
 

  reply	other threads:[~2006-08-01 16:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-31 13:55 [PATCH 0/6] AVR32 update for 2.6.18-rc2-mm1 Haavard Skinnemoen
2006-07-31 15:46 ` Haavard Skinnemoen
2006-07-31 18:40   ` Trond Myklebust
2006-08-01  8:12     ` Haavard Skinnemoen
2006-08-01 16:47       ` Trond Myklebust [this message]
2006-08-01 17:39         ` David Howells
2006-08-01 18:08           ` Trond Myklebust
2006-08-01 18:22         ` David Howells
2006-08-02  7:45         ` Haavard Skinnemoen
2006-08-03 14:34           ` Trond Myklebust
2006-08-03 15:33             ` Haavard Skinnemoen
2006-08-03 15:46             ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1154450847.5605.21.camel@localhost \
    --to=trond.myklebust@fys.uio.no \
    --cc=akpm@osdl.org \
    --cc=dhowells@redhat.com \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.