Re: [PATCH] Check battery after resume

[Thomas Renninger <trenn@suse.de>]

On Thu, 2006-08-03 at 15:02 -0400, Dave Jones wrote:
> On Thu, Aug 03, 2006 at 07:17:37PM +0200, Thomas Renninger wrote:
> 
>  > +/* 
>  > + * returns:
>  > + *   0 on success
>  > + *  <0 on failure
>  > + *   1 if new battery found
>  > + *   2 if battery got removed
>  > + */
> 
> Why make this so complicated...
> 
>  > +	result = acpi_battery_check(battery);
>  > +	if (result > 0){
>  > +		acpi_bus_generate_event(device,
>  > +					ACPI_NOTIFY_DEVICE_CHECK,
>  > +					battery->flags.present);
>  > +	}
>  > +	return 0;
>  > +}
> 
> When we simply treat the result as a boolean ?

The return value is used to:
   check for error                       <0
   success, no battery insertion/removal 0
   battery insertion/removal             >0  (1/2)

The latter one is needed to inform userspace to reread complete battery
information (possibly from other BATx dir) if battery has been
inserted/removed.

   Thomas