From: Rusty Russell <rusty@rustcorp.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: Re: 2.6.18-rc3-mm2 early_param mem= fix
Date: Mon, 07 Aug 2006 12:54:27 +1000 [thread overview]
Message-ID: <1154919267.21647.7.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0608061811030.19637@blonde.wat.veritas.com>
On Sun, 2006-08-06 at 18:22 +0100, Hugh Dickins wrote:
> but I wonder how many other early_param
> "option=" args are wrong (e.g. "memmap=" in the same file): x86_64
> shows many such, i386 shows only one, I've not followed it up further.
Thanks Hugh.
Andrew, here's that i386 fix:
Subject: Fix acpi_sci early_param
Unlike __setup which just does prefix matching, early_param does actual
command-line parsing (as module_param), so no "=" is needed or desired.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
--- linux-2.6.18-rc3-mm2/arch/i386/kernel/acpi/boot.c.~1~ 2006-08-07 12:40:14.000000000 +1000
+++ linux-2.6.18-rc3-mm2/arch/i386/kernel/acpi/boot.c 2006-08-07 12:49:42.000000000 +1000
@@ -1292,4 +1292,4 @@
return -EINVAL;
return 0;
}
-early_param("acpi_sci=", setup_acpi_sci);
+early_param("acpi_sci", setup_acpi_sci);
--
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law
next prev parent reply other threads:[~2006-08-07 2:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-06 17:22 2.6.18-rc3-mm2 early_param mem= fix Hugh Dickins
2006-08-06 17:31 ` Hugh Dickins
2006-08-07 15:08 ` Andy Whitcroft
2006-08-07 21:09 ` Eric W. Biederman
2006-08-09 0:10 ` Keith Mannthey
2006-08-09 1:03 ` Andi Kleen
2006-08-09 1:27 ` Rusty Russell
2006-08-06 19:15 ` Andrew Morton
2006-08-07 2:06 ` Andi Kleen
2006-08-07 2:54 ` Rusty Russell [this message]
2006-08-07 2:55 ` Andi Kleen
2006-08-07 3:08 ` Rusty Russell
2006-08-07 3:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154919267.21647.7.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.