From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Muli Ben-Yehuda <muli@il.ibm.com>
Cc: "Björn Steinbrink" <B.Steinbrink@gmx.de>,
linux-kernel@vger.kernel.org, dev@sw.ru, dev@openvz.org,
stable@kernel.org
Subject: Re: + sys_getppid-oopses-on-debug-kernel.patch added to -mm tree
Date: Tue, 08 Aug 2006 16:22:27 +0100 [thread overview]
Message-ID: <1155050547.5729.91.camel@localhost.localdomain> (raw)
In-Reply-To: <20060808145709.GB3953@rhun.haifa.ibm.com>
Ar Maw, 2006-08-08 am 17:57 +0300, ysgrifennodd Muli Ben-Yehuda:
> On Tue, Aug 08, 2006 at 04:51:38PM +0200, Björn Steinbrink wrote:
>
> > There's a note right above the function that explains it:
> > * NOTE! This depends on the fact that even if we _do_
> > * get an old value of "parent", we can happily dereference
> > * the pointer (it was and remains a dereferencable kernel pointer
> > * no matter what): we just can't necessarily trust the result
> > * until we know that the parent pointer is valid.
>
> Even without getting into just how ugly this is, is it really worth
> it?
It never was in my opinion but I lost that battle to Linus in 1.3.40 or
so timescales. Given how critical getppid _isnt_ I don't see the point
in being clever.
next prev parent reply other threads:[~2006-08-08 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200608081432.k78EWprf007511@shell0.pdx.osdl.net>
2006-08-08 14:39 ` + sys_getppid-oopses-on-debug-kernel.patch added to -mm tree Muli Ben-Yehuda
2006-08-08 14:51 ` Björn Steinbrink
2006-08-08 14:57 ` Muli Ben-Yehuda
2006-08-08 15:22 ` Alan Cox [this message]
2006-08-08 15:39 ` Kirill Korotaev
2006-08-08 16:36 ` Dave Jones
2006-08-09 8:12 ` Kirill Korotaev
2006-08-09 17:38 ` Dave Jones
2006-08-10 9:35 ` Kirill Korotaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155050547.5729.91.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=B.Steinbrink@gmx.de \
--cc=dev@openvz.org \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.