All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: How to lock current->signal->tty
Date: Tue, 08 Aug 2006 18:50:05 +0100	[thread overview]
Message-ID: <1155059405.5729.103.camel@localhost.localdomain> (raw)
In-Reply-To: <20060808164127.GA11392@intel.com>

Ar Maw, 2006-08-08 am 09:41 -0700, ysgrifennodd Luck, Tony:
> unaligned accesses at all is rather controversial.  So its a 50-50
> shot whether I'll fix it by adding the mutex_lock/mutex_unlock
> around the use of current->signal->tty, or just rip this out and
> just leave the printk().

Personally I'd just rip it out full stop. Its trivial to use kprobes and
friends to audit such things if there is a performance concern.

Alan


  reply	other threads:[~2006-08-08 17:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-08 15:17 How to lock current->signal->tty Alan Cox
2006-08-08 15:10 ` Arjan van de Ven
2006-08-08 15:44   ` Alan Cox
2006-08-08 16:41     ` Luck, Tony
2006-08-08 17:50       ` Alan Cox [this message]
2006-08-09  8:09         ` Jes Sorensen
2006-08-09 10:44           ` Alan Cox
2006-08-09 11:26             ` Jes Sorensen
2006-08-09 16:24             ` Luck, Tony
2006-08-09 18:10               ` Jes Sorensen
2006-08-08 22:06     ` Jan Kara
2006-08-08 17:11 ` Stephen Smalley
2006-08-08 17:43   ` Alan Cox
2006-08-08 17:44     ` Stephen Smalley
2006-08-08 18:10       ` Alan Cox
2006-08-08 20:02     ` Stephen Smalley
2006-08-13 21:34 ` Jan Kara
  -- strict thread matches above, loose matches on Subject: below --
2006-08-09  4:01 Albert Cahalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1155059405.5729.103.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.