From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH][0/2] RTAS MSI
Date: Wed, 09 Aug 2006 17:41:24 +0200 [thread overview]
Message-ID: <1155138084.17187.53.camel@localhost.localdomain> (raw)
In-Reply-To: <1155119228.6949.24.camel@localhost.localdomain>
> So I think we could have pci_enable_msi(dev), which would enable a
> single MSI _or_ MSI-X vector, depending on what's available. That'd be
> used by drivers that just want a simple replacement for LSI. And then
> pci_enable_multi_msi(dev, num_irqs) which would give the driver num_irqs
> MSI or MSI-X vectors.
You cannot lie and have pci_enable_msi() enable an MSI-X vector. Some
cards need additional tweaking when enabling MSI or MSI-X and if the
system enables MSI-X while the driver thinks it's MSI, bad things might
happen.
pci_enable_msi() should call the firmware to reconfigure for only one
MSI and enable just that. MSI-X is the only really sexy thing anyway
(that and a way to spread MSI-X accross CPUs from the kernel but that's
another topic)
Ben.
next prev parent reply other threads:[~2006-08-09 15:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-27 18:15 [PATCH][0/2] RTAS MSI Jake Moilanen
2006-07-27 18:17 ` [PATCH][1/2] export msi symbols Jake Moilanen
2006-07-27 18:41 ` Segher Boessenkool
2006-07-27 18:27 ` [PATCH][2/2] RTAS MSI Jake Moilanen
2006-07-27 18:46 ` Segher Boessenkool
2006-07-27 18:50 ` Segher Boessenkool
2006-07-27 19:34 ` Jake Moilanen
2006-07-27 20:35 ` Segher Boessenkool
2006-07-31 4:07 ` Paul Mackerras
2006-07-31 19:55 ` Jake Moilanen
2006-07-31 4:33 ` Michael Ellerman
2006-07-31 20:47 ` Jake Moilanen
2006-07-31 21:01 ` Jake Moilanen
2006-08-01 23:26 ` Michael Ellerman
2006-08-02 5:35 ` Segher Boessenkool
2006-08-02 9:04 ` Michael Ellerman
2006-08-09 9:50 ` Benjamin Herrenschmidt
2006-08-10 8:03 ` Michael Ellerman
2006-08-10 8:18 ` Benjamin Herrenschmidt
2006-07-28 4:56 ` [PATCH][0/2] " Benjamin Herrenschmidt
2006-07-28 18:43 ` Segher Boessenkool
2006-07-28 18:42 ` Jake Moilanen
2006-07-28 18:53 ` Segher Boessenkool
2006-08-09 2:23 ` Michael Ellerman
2006-08-09 9:52 ` Segher Boessenkool
2006-08-09 10:27 ` Michael Ellerman
2006-08-09 15:41 ` Benjamin Herrenschmidt [this message]
2006-08-10 8:22 ` Michael Ellerman
2006-08-10 9:23 ` Benjamin Herrenschmidt
2006-08-09 15:38 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155138084.17187.53.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.