Re: [PATCH 1/6] ehea: interface to network stack

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

On Thu, 2006-08-10 at 16:15 +1000, Michael Ellerman wrote:
> > +	struct hcp_query_ehea_port_cb_2 *cb2 = NULL;
> > +	struct net_device_stats *stats = &port->stats;
> > +
> > +	EDEB_EN(7, "net_device=%p", dev);
> > +
> > +	cb2 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> > +	if (!cb2) {
> > +		EDEB_ERR(4, "No memory for cb2");
> > +		goto get_stat_exit;
> 
> You leak cb2 here.
> 
> > +	}
> > +
> > +	hret = ehea_h_query_ehea_port(adapter->handle,
> > +				      port->logical_port_id,
> > +				      H_PORT_CB2,
> > +				      H_PORT_CB2_ALL,
> > +				      cb2);
> > +
> > +	if (hret != H_SUCCESS) {
> > +		EDEB_ERR(4, "query_ehea_port failed for cb2");
> > +		goto get_stat_exit;

Sorry, here.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]