From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: shemminger@osdl.org, netdev@vger.kernel.org,
kuznet@ms2.inr.ac.ru, herbert@gondor.apana.org.au
Subject: Re: [RFC][NET::SCHED]: cleanup qdisc_restart
Date: Mon, 14 Aug 2006 18:57:27 -0400 [thread overview]
Message-ID: <1155596247.6946.9.camel@jzny2> (raw)
In-Reply-To: <20060814.140136.88477982.davem@davemloft.net>
On Mon, 2006-14-08 at 14:01 -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Tue, 15 Aug 2006 07:42:39 -0700
>
> > Please don't change the values because some older drvers still return 1
> > rather
> > than NETDEV_TX_BUSY
>
> Unfortunately, this is probably very true. So we indeed cannot
> change the NETDEV_TX_BUSY value.
That slipped from the experiments i was trying out. I can use valid
return codes.
The question to ask though is: shouldnt we be having drivers use the
mnemonics instead of values like 1?
cheers,
jamal
next prev parent reply other threads:[~2006-08-14 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 18:43 [RFC][NET::SCHED]: cleanup qdisc_restart jamal
2006-08-15 14:42 ` Stephen Hemminger
2006-08-14 21:01 ` David Miller
2006-08-14 22:57 ` jamal [this message]
2006-08-14 23:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155596247.6946.9.camel@jzny2 \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.