From: Pavel Roskin <proski@gnu.org>
To: David Miller <davem@davemloft.net>
Cc: davej@redhat.com, netdev@vger.kernel.org, bunk@stusta.de
Subject: Re: [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()
Date: Tue, 15 Aug 2006 19:14:32 -0400 [thread overview]
Message-ID: <1155683672.5140.1.camel@dv> (raw)
In-Reply-To: <20060815.155417.112850438.davem@davemloft.net>
On Tue, 2006-08-15 at 15:54 -0700, David Miller wrote:
> > > /* These functions *must* be inline or they will break horribly on
> > > - * SPARC, due to its weird semantics for save/restore flags. extern
> > > - * inline should prevent the kernel from linking or module from
> > > - * loading if they are not inlined. */
> > > -extern inline int orinoco_lock(struct orinoco_private *priv,
> > > - unsigned long *flags)
> > > + * SPARC, due to its weird semantics for save/restore flags. */
> >
> > Didn't that get fixed up for SPARC a year or so back?
>
> That's right, this problem no longer exists.
Then, I guess, "static inline" would be just fine, right?
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2006-08-15 23:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 19:25 [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock() Pavel Roskin
2006-08-15 22:50 ` Dave Jones
2006-08-15 22:54 ` David Miller
2006-08-15 23:14 ` Pavel Roskin [this message]
2006-08-15 23:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155683672.5140.1.camel@dv \
--to=proski@gnu.org \
--cc=bunk@stusta.de \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.