From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@hp.com>
Subject: Re: Re: [XenPPC] [PATCH] [POWERPC] fix vga.c compilation
Date: Wed, 16 Aug 2006 07:59:39 -0600
Message-ID: <1155736779.8015.14.camel@lappy>
References: <C108B6C7.F2E%Keir.Fraser@cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C108B6C7.F2E%Keir.Fraser@cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-ia64-devel@lists.xensource.com, xen-devel@lists.xensource.com, Hollis Blanchard <hollisb@us.ibm.com>, xen-ppc-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2006-08-16 at 11:49 +0100, Keir Fraser wrote:
> Here you go. Arch/powerpc/vga.c isn't great but I assume it's
> temporary
> until vga support is fixed properly.
> 
> If you think it looks okay I'll apply it. Also Sign-off or Ack if you
> like.

Hi Keir,

   In general this looks a lot better, but I think ia64 is still going
to have trouble with the chunk below.  It seems that a VGA card
operating in a standard text mode doesn't necessarily respond to all of
these addresses.  On some ia64 platforms that causes a hard fail
response (the bus goes fatal and a reboot follows).  On my system, the
0xB8000 test looks like it will probably work, but we never get there
because either the 0xA0000 or the 0xB0000 test will cause the hardfail.
Do we need to poke the card through I/O port space to get it into the
right mode before probing it in MMIO space?  I don't know enough about
the VGA programming model to be able to do that.  The card works once we
start talking to it correctly, but this probe is a little too brute
force.  Thanks,

	Alex

> +
> +    p = ioremap(0xA0000, 0x1000);
> +    detected = detect_video(p);
> +    iounmap(p);
> +    if ( detected )
> +        return 1;
> +
> +    p = ioremap(0xB0000, 0x1000);
> +    detected = detect_video(p);
> +    iounmap(p);
> +    if ( detected )
> +        return 1;
> +
> +    p = ioremap(0xB8000, 0x1000);
> +    detected = detect_video(p);
> +    iounmap(p);
> +    if ( detected )
> +        return 1;
> + 
-- 
Alex Williamson                             HP Open Source & Linux Org.