From: Ingo Molnar <mingo@redhat.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Kernel development list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
David Woodhouse <dwmw2@infradead.org>,
Kai Petzke <wpp@marie.physik.tu-berlin.de>,
"Theodore Ts'o" <tytso@mit.edu>,
mingo@elte.hu
Subject: Re: Complaint about return code convention in queue_work() etc.
Date: Sun, 20 Aug 2006 13:06:21 +0200 [thread overview]
Message-ID: <1156071981.19017.60.camel@earth> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0608181730510.5732-100000@iolanthe.rowland.org>
On Fri, 2006-08-18 at 17:39 -0400, Alan Stern wrote:
> Why do the damn things return 0 for error and 1 for success???
> Why don't they use negative error codes for failure, like
> everything else in the kernel?!!
>
> I've tripped over this at least twice, and on each occasion spent a
> considerable length of time trying to track down the problem.
yeah, lets just flip the logic over, but combined with a rename so that
we dont surprise not-yet-in-tree code [and documentation/books].
queue_work() -> add_work() or something like that.
Ingo
prev parent reply other threads:[~2006-08-20 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 21:39 Complaint about return code convention in queue_work() etc Alan Stern
2006-08-18 21:43 ` Jeff Garzik
2006-08-18 22:41 ` Andrew Morton
2006-08-18 23:29 ` Alexey Dobriyan
2006-08-19 15:24 ` Alan Stern
2006-08-20 8:27 ` Jan Engelhardt
2006-08-20 16:58 ` Alan Stern
2006-08-20 22:06 ` Jan Engelhardt
2006-08-20 22:36 ` Alan Stern
2006-08-20 11:06 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156071981.19017.60.camel@earth \
--to=mingo@redhat.com \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stern@rowland.harvard.edu \
--cc=tytso@mit.edu \
--cc=wpp@marie.physik.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.