From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, mchehab@infradead.org
Subject: Re: [Patch] Fix signedness error in drivers/media/video/vivi.c
Date: Sun, 20 Aug 2006 19:25:27 +0100 [thread overview]
Message-ID: <1156098327.4051.36.camel@localhost.localdomain> (raw)
In-Reply-To: <1156004367.17863.2.camel@alice>
Ar Sad, 2006-08-19 am 18:19 +0200, ysgrifennodd Eric Sesterhenn:
> Since videobuf_reqbufs() returns negative values on errors the current
> code does no real error checking since gcc removes the comparison.
> This patch fixes this issue by making ret a normal, signed integer.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
Doesn't apply to latest driver tree but the problem is still present.
Alan
next prev parent reply other threads:[~2006-08-20 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-19 16:19 [Patch] Fix signedness error in drivers/media/video/vivi.c Eric Sesterhenn
2006-08-20 18:25 ` Alan Cox [this message]
2006-08-21 15:10 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156098327.4051.36.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.