From: "Clemens Ladisch" <clemens@ladisch.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: [alsa-cvslog] alsa-kernel: fm801: move CONFIG_VIDEO_DEV dependency to CONFIG_SND_FM801_TEA575X_BOOL
Date: Mon, 21 Aug 2006 09:52:05 +0200 [thread overview]
Message-ID: <1156146725.19545.269017711@webmail.messagingengine.com> (raw)
In-Reply-To: <s5h4pwa14xu.wl%tiwai@suse.de>
Takashi Iwai wrote:
> [...]
> I meant CONFIG_SND_FM801_TEA575X in the external alsa-driver tree is
> never set to y or m. It's always n. This is because
> CONFIG_SND_FM801_TEA575X is evaluated before *_TEA575X_BOOL.
Okay, I reverted my Kconfig change.
I tried to use this patch to manually evaluate the TEA575X symbols:
--- alsa.orig/alsa-driver/configure.in 2006-08-20 11:38:22.000000000 +0200
+++ alsa/alsa-driver/configure.in 2006-08-21 01:04:13.000000000 +0200
@@ -2548,6 +2548,14 @@
CONFIG_SOUND=m
ALSA_TOPLEVEL_SELECT
+dnl Workaround for module->option dependency
+if ( test "$CONFIG_SND_FM801_TEA575X_BOOL" = "y" ) &&
+ ( test "$CONFIG_VIDEO_DEV" = "y" ); then
+ CONFIG_SND_FM801_TEA575X="m"
+else
+ CONFIG_SND_FM801_TEA575X_BOOL=""
+fi
+
dnl OSS emulations
if test "$CONFIG_SND_OSSEMUL" = "y"; then
CONFIG_SND_MIXER_OSS="$CONFIG_SND"
However, this results in include/config1.h and toplevel.config being
inconsistent. Apparently, autoconf writes the symbols to config1.h when
AC_DEFINE is called, but writes to toplevel.config when AC_SUBST is
called. This means that the above workaround gets applied after
config1.h was written.
The obvious solution would be to move the AC_DEFINE()s out of
ALSA_TOPLEVEL_SELECT into a new macro or into ALSA_TOPLEVEL_OUTPUT.
However, this may also change the values of the OSS symbols that are
written to config1.h (which is done before the assignments under "OSS
emulations"), and I'm not sure if this change might break anything.
Regards,
Clemens
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2006-08-21 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ALOGGER1155885865.57@alsa-project.org>
2006-08-18 8:04 ` [alsa-cvslog] alsa-kernel: fm801: move CONFIG_VIDEO_DEV dependency to CONFIG_SND_FM801_TEA575X_BOOL Takashi Iwai
2006-08-18 8:56 ` Clemens Ladisch
2006-08-18 9:10 ` Takashi Iwai
2006-08-18 9:25 ` Clemens Ladisch
2006-08-18 9:40 ` Takashi Iwai
2006-08-18 14:35 ` Clemens Ladisch
2006-08-18 14:42 ` Takashi Iwai
2006-08-21 7:52 ` Clemens Ladisch [this message]
2006-08-21 12:32 ` Takashi Iwai
2006-08-22 7:31 ` Clemens Ladisch
2006-08-22 11:27 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156146725.19545.269017711@webmail.messagingengine.com \
--to=clemens@ladisch.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.