From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "Steve French (smfltc)" <smfltc@us.ibm.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: generic_file_llseek vs. remote_llseek
Date: Tue, 22 Aug 2006 16:00:24 -0400 [thread overview]
Message-ID: <1156276825.6921.41.camel@localhost> (raw)
In-Reply-To: <44EB5FB2.8090005@us.ibm.com>
On Tue, 2006-08-22 at 14:49 -0500, Steve French (smfltc) wrote:
> Now that generic_file_llseek locks the inode, do we need to have anyone
> use remote_llseek?
>
> Although remote_llseek is newer, it does a lock_kernel which seems
> excessive, unless it has to do with
> some isize_write race issue it is trying to avoid.
>
> The cifs code would probably be fine with the change to the (presumably
> faster) generic_file_llseek,
> and perhas the nfs code as weel..
NFS has issues with isize_write(). We can't use it 'cos it presupposes
that all size changes will occur under the inode->i_mutex.
Unfortunately, remote servers don't take our local inode->i_mutex.
Cheers,
Trond
prev parent reply other threads:[~2006-08-22 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 19:49 generic_file_llseek vs. remote_llseek Steve French (smfltc)
2006-08-22 20:00 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156276825.6921.41.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfltc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.