From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@hp.com>
Subject: Re: [POWERPC/IA64] Updates required due to loader changes
Date: Thu, 24 Aug 2006 14:16:03 -0600
Message-ID: <1156450563.5591.17.camel@lappy>
References: <1156341628.12949.48.camel@localhost.localdomain>
	<1156343769.12949.59.camel@localhost.localdomain>
	<1156355091.12949.136.camel@localhost.localdomain>
	<1156356541.7960.49.camel@basalt.austin.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1156356541.7960.49.camel@basalt.austin.ibm.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: Jimi Xenidis <jimix@watson.ibm.com>, xen-devel <xen-devel@lists.xensource.com>, Ian Campbell <Ian.Campbell@xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2006-08-23 at 13:09 -0500, Hollis Blanchard wrote:
> On Wed, 2006-08-23 at 18:44 +0100, Ian Campbell wrote:
> > Does it make sense to add a token set of ELF notes to your kernels? I
> > think XEN_VERSION, GUEST_OS and GUEST_VERSION would do the job...
> 
> I don't have any objection in principle.

   I don't have any objection to it either.  As Tristan mentioned for
ia64, we don't actually build the code in the proposed ia64 patch, so I
think we'll be fine for the moment.  One problem though is that
readnote.c will fail to build on all non-x86 architectures.  The patch
below makes it build, but I haven't actually tested the functionality.
PPC may want something similar.  Ian, could you commit this?  Thanks,

	Alex

Signed-off-by: Alex Williamson <alex.williamson@hp.com>
---

diff -r d5eb5205ff35 tools/xcutils/readnotes.c
--- a/tools/xcutils/readnotes.c	Thu Aug 24 16:25:49 2006 +0100
+++ b/tools/xcutils/readnotes.c	Thu Aug 24 14:12:45 2006 -0600
@@ -22,7 +22,7 @@ typedef Elf32_Nhdr Elf_Nhdr;
 typedef Elf32_Nhdr Elf_Nhdr;
 typedef Elf32_Half Elf_Half;
 typedef Elf32_Word Elf_Word;
-#elif defined(__x86_64__)
+#elif defined(__x86_64__) || defined(__ia64__)
 typedef Elf64_Ehdr Elf_Ehdr;
 typedef Elf64_Nhdr Elf_Nhdr;
 typedef Elf64_Half Elf_Half;