Re: site/* - using common files for site information

[Richard Purdie <rpurdie@rpsys.net>]

On Fri, 2006-08-25 at 18:22 +1000, Jamie Lenehan wrote:
> On Fri, Aug 25, 2006 at 09:08:09AM +0100, Richard Purdie wrote:
> I changed my mind about a dozen times on this, so seeing what someone
> else thinks would be good. 

I'll try and take a look at the patches this weekend. I can't promise
but I will try :).

> > review the patches. The name info.bbclass is perhaps too generic though
> > - could you call it something like autotools-info.bbclass?
> 
> The reason I called it info.bbclass is because it's not actually
> related to autotools. What it does is provide information about a
> target - endianess, 32/64 bit, which libc it's using, what alias
> exists for it in a general sort of way.
> 
> The autotools.bbclass then makes use of this to decided which site
> files to use.

You can argue that both ways. Ultimately, those files are generally used
by configure which implies autotools but other packages also use them to
provide supplementary info, just to confuse the issue :). I like the
idea of some functions like get_info_endianess_select (although your
example doesn't quite match with get_info_choice_endianess) and it would
be good to abstract direct access to the site files.

I still feel info is too generic as we have 101 different forms of info
around and we need to find a better more descriptive name.
config-info.bclass? site-config.bbclass? Calling it autotools-info
doesn't mean none autotooled packages can't use it btw!

> I also made use of the info.bbclass to provide the endiness
> information to recipes that were currently manaully looking in the
> site file to determine this (since the way they currently work breaks
> with the site file.)

Just throwing ideas around, rather than create a function for each
option like endiness, why not have a variable which contains the
endiness set by the class and use base_conditional to get the value you
want? This might make things a little more flexiable?

Cheers,

Richard