From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: New serial speed handling: First implementation
Date: Fri, 25 Aug 2006 21:44:57 +0100 [thread overview]
Message-ID: <1156538697.3007.256.camel@localhost.localdomain> (raw)
In-Reply-To: <20060825174131.GA725@flint.arm.linux.org.uk>
Ar Gwe, 2006-08-25 am 18:41 +0100, ysgrifennodd Russell King:
> On Fri, Aug 25, 2006 at 04:15:53PM +0100, Alan Cox wrote:
> > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc4-mm2/include/asm-i386/ioctls.h linux-2.6.18-rc4-mm2/include/asm-i386/ioctls.h
> > --- linux.vanilla-2.6.18-rc4-mm2/include/asm-i386/ioctls.h 2006-08-21 14:17:52.000000000 +0100
> > +++ linux-2.6.18-rc4-mm2/include/asm-i386/ioctls.h 2006-08-25 11:23:20.000000000 +0100
> > @@ -47,6 +47,12 @@
> > #define TIOCSBRK 0x5427 /* BSD compatibility */
> > #define TIOCCBRK 0x5428 /* BSD compatibility */
> > #define TIOCGSID 0x5429 /* Return the session ID of FD */
> > +
> > +#define TCGETS2 0x542A
> > +#define TCSETS2 0x542B
> > +#define TCSETSW2 0x542C
> > +#define TCSETSF2 0x542D
> > +
>
> Wouldn't it be better to use the _IO* macros to define these new ioctls?
> Ditto for other architectures.
That really is up to you. For x86/x86-64 it would break the internal
consistency.
next prev parent reply other threads:[~2006-08-25 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 15:15 New serial speed handling: First implementation Alan Cox
2006-08-25 17:41 ` Russell King
2006-08-25 20:44 ` Alan Cox [this message]
2006-08-25 23:21 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156538697.3007.256.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.