From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Peterson <rpeterso@redhat.com>
Date: Tue, 6 Sep 2011 14:29:24 -0400 (EDT)
Subject: [Cluster-devel] [PATCH 3/3] mkfs i18n:
In-Reply-To: <1315330915-15039-1-git-send-email-cmaiolino@redhat.com>
Message-ID: <1156607657.11551.1315333764000.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi Carlos,

----- Original Message -----
| + do{
| + printf( _("\nAre you sure you want to proceed? [y/n]"));
| + ret = getline(&line, &len, stdin);
| + res = rpmatch(line);

I'd like to see the free(line); moved right here after rpmatch.
Otherwise multiple iterations through the loop will leak memory.

| +
| + if (res > 0){

With my suggestion above, this can be removed:
| + free(line);

Other than that, it looks good.

Regards,

Bob Peterson
Red Hat File Systems