From: Hong Liu <hong.liu@intel.com>
To: jbenc@suse.cz
Cc: netdev@vger.kernel.org
Subject: [PATCH]d80211: fix "iwconfig key [x]" behavior
Date: Mon, 28 Aug 2006 16:36:39 +0800 [thread overview]
Message-ID: <1156754199.6061.3.camel@devlinux-hong> (raw)
[-- Attachment #1: Type: text/plain, Size: 136 bytes --]
"iwconfig key [x]" behavior is not correctly handled in the stack, also
modify the giwencode method to show the key info.
Thanks,
Hong
[-- Attachment #2: d80211-fix-iwconfig-key.patch --]
[-- Type: text/x-patch, Size: 1861 bytes --]
[PATCH]d80211: fix "iwconfig key [x]" behavior
Signed-off-by: Hong Liu <hong.liu@intel.com>
diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c
index dd52555..d3dc59c 100644
--- a/net/d80211/ieee80211_ioctl.c
+++ b/net/d80211/ieee80211_ioctl.c
@@ -2811,9 +2811,10 @@ static int ieee80211_ioctl_siwencode(str
if (sdata->default_key == NULL)
idx = 0;
else for (i = 0; i < NUM_DEFAULT_KEYS; i++) {
- if (sdata->default_key == sdata->keys[i])
+ if (sdata->default_key == sdata->keys[i]) {
idx = i;
- break;
+ break;
+ }
}
if (idx < 0)
return -EINVAL;
@@ -2824,16 +2825,22 @@ static int ieee80211_ioctl_siwencode(str
alg = ALG_NONE;
else if (erq->length == 0) {
/* No key data - just set the default TX key index */
- sdata->default_key = sdata->keys[idx];
+ if (sdata->default_key != sdata->keys[idx]) {
+ if (sdata->default_key)
+ ieee80211_key_sysfs_remove_default(sdata);
+ sdata->default_key = sdata->keys[idx];
+ if (sdata->default_key)
+ ieee80211_key_sysfs_add_default(sdata);
+ }
+ return 0;
}
return ieee80211_set_encryption(
dev, bcaddr,
- idx, erq->length == 0 ? ALG_NONE : ALG_WEP,
+ idx, alg,
sdata->default_key == NULL,
NULL, keybuf, erq->length);
- return 0;
}
@@ -2852,9 +2859,10 @@ static int ieee80211_ioctl_giwencode(str
if (sdata->default_key == NULL)
idx = 0;
else for (i = 0; i < NUM_DEFAULT_KEYS; i++) {
- if (sdata->default_key == sdata->keys[i])
+ if (sdata->default_key == sdata->keys[i]) {
idx = i;
- break;
+ break;
+ }
}
if (idx < 0)
return -EINVAL;
@@ -2869,7 +2877,8 @@ static int ieee80211_ioctl_giwencode(str
return 0;
}
- erq->length = 0;
+ erq->length = sdata->keys[idx]->keylen;
+ memcpy(key, sdata->keys[idx]->key, erq->length);
erq->flags |= IW_ENCODE_ENABLED;
return 0;
next reply other threads:[~2006-08-28 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 8:36 Hong Liu [this message]
2006-08-30 17:24 ` [PATCH]d80211: fix "iwconfig key [x]" behavior Jiri Benc
2006-09-01 3:37 ` Hong Liu
2006-09-21 15:51 ` Jiri Benc
2006-09-22 7:56 ` Hong Liu
2006-09-22 12:00 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156754199.6061.3.camel@devlinux-hong \
--to=hong.liu@intel.com \
--cc=jbenc@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.