From mboxrd@z Thu Jan  1 00:00:00 1970
From: Harry Butterworth <harry@hebutterworth.freeserve.co.uk>
Subject: [PATCH] [UNTESTED] Fix sentinel in call to execlp in
	tools/iommu/vnc.c
Date: Wed, 30 Aug 2006 17:31:27 +0100
Message-ID: <1156955488.7718.11.camel@localhost.localdomain>
References: <44F5B588.4090505@us.ibm.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-R7Fq6JNpsAKO9vFrQRlX"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <44F5B588.4090505@us.ibm.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: David F Barrera <dfbp@us.ibm.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org


--=-R7Fq6JNpsAKO9vFrQRlX
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Wed, 2006-08-30 at 10:58 -0500, David F Barrera wrote:
> August 30, 2006, using xen-unstable changeset:
> 
> changeset:   11288:a47951e59cbf

> ISSUES:
> 
> x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
> 
> Unable to start xen on this machine. Build log shows:
> 
> /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: warning: missing sentinel in function call
> make[3]: *** [vnc.o] Error 1
> make[2]: *** [subdir-i386-dm] Error 2
> make[1]: *** [ioemu] Error 2
> make: *** [all] Error 2
> ...
> make[3]: *** [vnc.o] Error 1
> make[2]: *** [subdir-i386-dm] Error 2
> make[1]: *** [ioemuinstall] Error 2
> make: *** [install] Error 2"

This patch should fix your problem here.  I have not tested it.  Please
give it a go and report whether it is OK to be committed to the tree.

The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the
sentinel needs to be a 64 bit null pointer for the code to be correct.

Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com>

--=-R7Fq6JNpsAKO9vFrQRlX
Content-Disposition: attachment; filename=sentinel.patch
Content-Type: text/x-patch; name=sentinel.patch; charset=utf-8
Content-Transfer-Encoding: 7bit

diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c
--- a/tools/ioemu/vnc.c	Wed Aug 30 10:05:00 2006
+++ b/tools/ioemu/vnc.c	Wed Aug 30 16:23:38 2006
@@ -1269,7 +1269,7 @@
 	exit(1);
 
     case 0:	/* child */
-	execlp("vncviewer", "vncviewer", s, 0);
+	execlp("vncviewer", "vncviewer", s, (char *)NULL);
 	fprintf(stderr, "vncviewer execlp failed\n");
 	exit(1);
 

--=-R7Fq6JNpsAKO9vFrQRlX
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--=-R7Fq6JNpsAKO9vFrQRlX--