From: Eric Paris <eparis@parisplace.org>
To: Steve French <smfrench@austin.rr.com>
Cc: jmorris@redhat.com, linux-kernel@vger.kernel.org,
shaggy@austin.ibm.com, shirishp@us.ibm.com, akpm@osdl.org
Subject: Re: [PATCH] SELinux: work around filesystems which call d_instantiate before setting inode mode
Date: Wed, 30 Aug 2006 13:52:32 -0400 [thread overview]
Message-ID: <1156960352.3195.56.camel@localhost.localdomain> (raw)
In-Reply-To: <44F50D86.8050706@austin.rr.com>
On Tue, 2006-08-29 at 23:01 -0500, Steve French wrote:
> Eric,
> Does this patch do what you need?
>
> It rearranges the cifs call to d_instantiate until after the inode is
> filled in in fs/cifs/readdir.c
> which IIRC was the only place which did the reverse order from what you
> expected (at
> least the only place in cifs). I will try it tomorrow but I don't know
> SE Linux
> scenarios to try that would prove whether it works.
This patch does seem to solve the issue with CIFS that we were
experiencing and I would love to see it submitted.
I would also like to have my original patch included as it will help to
flush out any other cases of this ordering in the future.
-Eric
next prev parent reply other threads:[~2006-08-30 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF333D0451.97EE96CD-ON872571DA.001579E9-862571DA.001591D1@us.ibm.com>
2006-08-30 4:01 ` [PATCH] SELinux: work around filesystems which call d_instantiate before setting inode mode Steve French
2006-08-30 17:52 ` Eric Paris [this message]
2006-08-29 20:08 Eric Paris
2006-08-29 20:13 ` Benjamin LaHaise
2006-08-29 21:02 ` Eric Paris
-- strict thread matches above, loose matches on Subject: below --
2006-08-25 19:48 Eric Paris
2006-08-28 17:43 ` Stephen Smalley
2006-08-29 4:15 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156960352.3195.56.camel@localhost.localdomain \
--to=eparis@parisplace.org \
--cc=akpm@osdl.org \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@austin.ibm.com \
--cc=shirishp@us.ibm.com \
--cc=smfrench@austin.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.