From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [RFC: 2.6 patch] build sound/sound_firmware.c only for OSS Date: Mon, 04 Sep 2006 13:11:04 +0100 Message-ID: <1157371864.30801.38.camel@localhost.localdomain> References: <20060904114135.GO4416@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from gate.perex.cz (gate.perex.cz [85.132.177.35]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id B987529A for ; Mon, 4 Sep 2006 13:48:28 +0200 (MEST) Received: from lxorguk.ukuu.org.uk (unknown [81.2.110.250]) by gate.perex.cz (Perex's E-mail Delivery System) with ESMTP id EF50D69524 for ; Mon, 4 Sep 2006 13:48:27 +0200 (MEST) In-Reply-To: <20060904114135.GO4416@stusta.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Adrian Bunk Cc: Andrew Morton , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org Ar Llu, 2006-09-04 am 13:41 +0200, ysgrifennodd Adrian Bunk: > All sound/sound_firmware.c contains is mod_firmware_load() that is a > legacy API only used by some OSS drivers. > > This patch builds it into an own sound_firmware module that is only > built depending on CONFIG_SOUND_PRIME making the kernel slightly smaller > for ALSA users. Reminds me - might as well fix this too Signed-off-by: Alan Cox --- sound/sound_firmware.c~ 2006-09-04 12:33:08.805282488 +0100 +++ sound/sound_firmware.c 2006-09-04 12:33:08.817280664 +0100 @@ -59,8 +59,7 @@ * value zero on a failure. * * Caution: This API is not recommended. Firmware should be loaded via - * an ioctl call and a setup application. This function may disappear - * in future. + * request_firmware. */ int mod_firmware_load(const char *fn, char **fp) ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964814AbWIDLuk (ORCPT ); Mon, 4 Sep 2006 07:50:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964822AbWIDLuk (ORCPT ); Mon, 4 Sep 2006 07:50:40 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:48791 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S964814AbWIDLuj (ORCPT ); Mon, 4 Sep 2006 07:50:39 -0400 Subject: Re: [RFC: 2.6 patch] build sound/sound_firmware.c only for OSS From: Alan Cox To: Adrian Bunk Cc: Andrew Morton , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org In-Reply-To: <20060904114135.GO4416@stusta.de> References: <20060904114135.GO4416@stusta.de> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Mon, 04 Sep 2006 13:11:04 +0100 Message-Id: <1157371864.30801.38.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.2 (2.6.2-1.fc5.5) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ar Llu, 2006-09-04 am 13:41 +0200, ysgrifennodd Adrian Bunk: > All sound/sound_firmware.c contains is mod_firmware_load() that is a > legacy API only used by some OSS drivers. > > This patch builds it into an own sound_firmware module that is only > built depending on CONFIG_SOUND_PRIME making the kernel slightly smaller > for ALSA users. Reminds me - might as well fix this too Signed-off-by: Alan Cox --- sound/sound_firmware.c~ 2006-09-04 12:33:08.805282488 +0100 +++ sound/sound_firmware.c 2006-09-04 12:33:08.817280664 +0100 @@ -59,8 +59,7 @@ * value zero on a failure. * * Caution: This API is not recommended. Firmware should be loaded via - * an ioctl call and a setup application. This function may disappear - * in future. + * request_firmware. */ int mod_firmware_load(const char *fn, char **fp) -- VGER BF report: H 2.96182e-15