From: Stian Jordet <liste@jordet.net>
To: Sergio Monteiro Basto <sergio@sergiomb.no-ip.org>
Cc: Daniel Drake <dsd@gentoo.org>, Linus Torvalds <torvalds@osdl.org>,
akpm@osdl.org, jeff@garzik.org, greg@kroah.com, cw@f00f.org,
bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, harmon@ksu.edu, len.brown@intel.com,
vsu@altlinux.ru
Subject: Re: [NEW PATCH] VIA IRQ quirk behaviour change
Date: Thu, 07 Sep 2006 23:07:45 +0200 [thread overview]
Message-ID: <1157663265.4075.3.camel@localhost> (raw)
In-Reply-To: <1157629436.2369.7.camel@localhost.localdomain>
tor, 07,.09.2006 kl. 12.43 +0100, skrev Sergio Monteiro Basto:
> the statment was write by Linus on http://lkml.org/lkml/2005/9/27/113
> my patch don't quirk any device if we are working on IO-APIC,
> Linus simply know if a interrupt is > 15 we are working on IO-APIC and
> just don't quirk irq > 15
>
> > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > > --- a/drivers/pci/quirks.c
> > > +++ b/drivers/pci/quirks.c
> > > @@ -546,7 +546,10 @@ static void quirk_via_irq(struct pci_dev
> > > {
> > > u8 irq, new_irq;
> > >
> > > - new_irq = dev->irq & 0xf;
> > > + new_irq = dev->irq;
> > > + if (!new_irq || new_irq >= 15)
> > > + return;
> > > +
> > > pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
> > > if (new_irq != irq) {
After a quick test tonight, this patch seems to work nicely for me. (I
know I told Linux that it didn't, don't know what's changed). Does this
fix the problems other people is having as well? If so, that would be
nice :)
Thanks.
-Stian
prev parent reply other threads:[~2006-09-07 21:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 2:04 [NEW PATCH] VIA IRQ quirk behaviour change Daniel Drake
2006-09-06 9:02 ` Stian Jordet
2006-09-05 2:39 ` Daniel Drake
2006-09-06 15:49 ` Stian Jordet
2006-09-06 23:49 ` Daniel Drake
2006-09-07 2:00 ` Sergio Monteiro Basto
2006-09-07 3:47 ` Daniel Drake
2006-09-07 11:43 ` Sergio Monteiro Basto
2006-09-07 21:07 ` Stian Jordet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157663265.4075.3.camel@localhost \
--to=liste@jordet.net \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bjorn.helgaas@hp.com \
--cc=cw@f00f.org \
--cc=dsd@gentoo.org \
--cc=greg@kroah.com \
--cc=harmon@ksu.edu \
--cc=jeff@garzik.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergio@sergiomb.no-ip.org \
--cc=torvalds@osdl.org \
--cc=vsu@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.