From: Dave Hansen <haveblue@us.ibm.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Containers <containers@lists.osdl.org>,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [PATCH] vt: Make vt_pid a struct pid (making it pid wrap around safe).
Date: Mon, 11 Sep 2006 10:24:50 -0700 [thread overview]
Message-ID: <1157995490.26324.106.camel@localhost.localdomain> (raw)
In-Reply-To: <m1u03fevvz.fsf@ebiederm.dsl.xmission.com>
On Sun, 2006-09-10 at 06:41 -0600, Eric W. Biederman wrote:
>
> - vc->vt_pid = current->pid;
> + put_pid(xchg(&vc->vt_pid, get_pid(task_pid(current))));
Would it make any sense to have a get_current_pid()? It might reduce
the horribly confusing number of parenthesis there.
-- Dave
prev parent reply other threads:[~2006-09-11 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-10 12:41 [PATCH] vt: Make vt_pid a struct pid (making it pid wrap around safe) Eric W. Biederman
2006-09-11 5:28 ` Eric W. Biederman
2006-09-11 15:12 ` Oleg Nesterov
2006-09-11 17:24 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157995490.26324.106.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.