All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mxser: PCI refcounts
Date: Sat, 16 Sep 2006 18:02:38 +0100	[thread overview]
Message-ID: <1158426158.6069.9.camel@localhost.localdomain> (raw)
In-Reply-To: <450BF0A1.4040807@gmail.com>

Ar Sad, 2006-09-16 am 14:39 +0159, ysgrifennodd Jiri Slaby:
> Alan Cox wrote:
> > Switch to pci ref counts for mxser when handling PCI devices. Use
> > pci_get_device and drop the reference when we finish and unload.
> 
> Please, don't do that. These all drivers need to be rewritten to pci probing 
> (for this one I have a patch, but I waited for confirmation of previous 
> patchset, but nothing has come, so perhaps I will clone it as NEW/EXPERIMENTAL 
> 1.9.1-with-pci-probing-driver) and when pci_find_device is there, we can `grep 
> -r` it to know, which drivers need that. The same holds for zoran cards, which 
> somebody wanted to play with (and rework), but as I can see, nothing happened :/.

Well if they need pci probing updates perhaps we should either apply the
alternative patches and see what breaks, or delete the driver and see
who screams.

Alan


      parent reply	other threads:[~2006-09-16 16:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-15 14:12 [PATCH] mxser: PCI refcounts Alan Cox
2006-09-16 12:40 ` Jiri Slaby
2006-09-16 12:58   ` Jiri Slaby
2006-09-16 17:02   ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1158426158.6069.9.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@osdl.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.