From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Thu, 26 Feb 2015 20:46:47 +0200 Subject: [PATCH 04/11] dt-bindings: Add documentation for rockchip lvds In-Reply-To: <1422721984-27782-5-git-send-email-heiko@sntech.de> References: <1422721984-27782-1-git-send-email-heiko@sntech.de> <1422721984-27782-5-git-send-email-heiko@sntech.de> Message-ID: <11587309.c7unAcH6bR@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko, Thank you for the patch. On Saturday 31 January 2015 17:32:57 Heiko Stuebner wrote: > From: Mark Yao > > Add binding documentation for Rockchip SoC LVDS driver. > > Signed-off-by: Mark Yao > Signed-off-by: Heiko Stuebner > --- > .../devicetree/bindings/video/rockchip-lvds.txt | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/video/rockchip-lvds.txt > > diff --git a/Documentation/devicetree/bindings/video/rockchip-lvds.txt > b/Documentation/devicetree/bindings/video/rockchip-lvds.txt new file mode > 100644 > index 0000000..1616d7e > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/rockchip-lvds.txt > @@ -0,0 +1,59 @@ > +Rockchip RK3288 LVDS interface > +================================ > + > +Required properties: > +- compatible: "rockchip,rk3288-lvds"; > + > +- reg: physical base address of the controller and length > + of memory mapped region. > +- clocks: must include clock specifiers corresponding to entries in the > + clock-names property. > +- clock-names: must contain "pclk_lvds" > + > +- avdd1v0-supply: regulator phandle for 1.0V analog power > +- avdd1v8-supply: regulator phandle for 1.8V analog power > +- avdd3v3-supply: regulator phandle for 3.3V analog power > + > +- rockchip,grf: phandle to the general register files syscon > +- rockchip,panel: phandle to a panel node as described by > + Documentation/devicetree/bindings/panel/* Doesn't this duplicate the information provided by the ports ? > +- rockchip,data-mapping: should be "vesa" or "jeida", > + This describes how the color bits are laid out in the > + serialized LVDS signal. > +- rockchip,data-width : should be <18> or <24>; > +- rockchip,output: should be "rgb", "lvds" or "duallvds", > + This describes the output face. Isn't all this panel-dependent ? Could we query the information from the panel at runtime instead ? > +- ports: contain a port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + > +Example: > + lvds: lvds at ff96c000 { > + compatible = "rockchip,rk3288-lvds"; > + rockchip,grf = <&grf>; > + reg = <0xff96c000 0x4000>; > + clocks = <&cru PCLK_LVDS_PHY>; > + clock-names = "pclk_lvds"; > + avdd1v0-supply = <&vdd10_lcd>; > + avdd1v8-supply = <&vcc18_lcd>; > + avdd3v3-supply = <&vcca_33>; > + rockchip,panel = <&panel>; > + rockchip,data-mapping = "jeida"; > + rockchip,data-width = <24>; > + rockchip,output = "rgb"; > + ports { > + lvds_in: port { > + #address-cells = <1>; > + #size-cells = <0>; > + lvds_in_vopb: endpoint at 0 { > + reg = <0>; > + remote-endpoint = <&vopb_out_lvds>; > + }; > + lvds_in_vopl: endpoint at 1 { > + reg = <1>; > + remote-endpoint = <&vopl_out_lvds>; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 04/11] dt-bindings: Add documentation for rockchip lvds Date: Thu, 26 Feb 2015 20:46:47 +0200 Message-ID: <11587309.c7unAcH6bR@avalon> References: <1422721984-27782-1-git-send-email-heiko@sntech.de> <1422721984-27782-5-git-send-email-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1422721984-27782-5-git-send-email-heiko@sntech.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, Mark Yao , robh+dt@kernel.org, galak@codeaurora.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgSGVpa28sCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFNhdHVyZGF5IDMxIEphbnVh cnkgMjAxNSAxNzozMjo1NyBIZWlrbyBTdHVlYm5lciB3cm90ZToKPiBGcm9tOiBNYXJrIFlhbyA8 eXpxQHJvY2stY2hpcHMuY29tPgo+IAo+IEFkZCBiaW5kaW5nIGRvY3VtZW50YXRpb24gZm9yIFJv Y2tjaGlwIFNvQyBMVkRTIGRyaXZlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYXJrIFlhbyA8eXpx QHJvY2stY2hpcHMuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEhlaWtvIFN0dWVibmVyIDxoZWlrb0Bz bnRlY2guZGU+Cj4gLS0tCj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3ZpZGVvL3JvY2tjaGlw LWx2ZHMudHh0ICAgIHwgNTkgKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwg NTkgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQKPiBEb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvdmlkZW8vcm9ja2NoaXAtbHZkcy50eHQKPiAKPiBkaWZmIC0tZ2l0 IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3ZpZGVvL3JvY2tjaGlwLWx2ZHMu dHh0Cj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdmlkZW8vcm9ja2NoaXAt bHZkcy50eHQgbmV3IGZpbGUgbW9kZQo+IDEwMDY0NAo+IGluZGV4IDAwMDAwMDAuLjE2MTZkN2UK PiAtLS0gL2Rldi9udWxsCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L3ZpZGVvL3JvY2tjaGlwLWx2ZHMudHh0Cj4gQEAgLTAsMCArMSw1OSBAQAo+ICtSb2NrY2hpcCBS SzMyODggTFZEUyBpbnRlcmZhY2UKPiArPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K PiArCj4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gKy0gY29tcGF0aWJsZTogInJvY2tjaGlwLHJr MzI4OC1sdmRzIjsKPiArCj4gKy0gcmVnOiBwaHlzaWNhbCBiYXNlIGFkZHJlc3Mgb2YgdGhlIGNv bnRyb2xsZXIgYW5kIGxlbmd0aAo+ICsJb2YgbWVtb3J5IG1hcHBlZCByZWdpb24uCj4gKy0gY2xv Y2tzOiBtdXN0IGluY2x1ZGUgY2xvY2sgc3BlY2lmaWVycyBjb3JyZXNwb25kaW5nIHRvIGVudHJp ZXMgaW4gdGhlCj4gKwljbG9jay1uYW1lcyBwcm9wZXJ0eS4KPiArLSBjbG9jay1uYW1lczogbXVz dCBjb250YWluICJwY2xrX2x2ZHMiCj4gKwo+ICstIGF2ZGQxdjAtc3VwcGx5OiByZWd1bGF0b3Ig cGhhbmRsZSBmb3IgMS4wViBhbmFsb2cgcG93ZXIKPiArLSBhdmRkMXY4LXN1cHBseTogcmVndWxh dG9yIHBoYW5kbGUgZm9yIDEuOFYgYW5hbG9nIHBvd2VyCj4gKy0gYXZkZDN2My1zdXBwbHk6IHJl Z3VsYXRvciBwaGFuZGxlIGZvciAzLjNWIGFuYWxvZyBwb3dlcgo+ICsKPiArLSByb2NrY2hpcCxn cmY6IHBoYW5kbGUgdG8gdGhlIGdlbmVyYWwgcmVnaXN0ZXIgZmlsZXMgc3lzY29uCj4gKy0gcm9j a2NoaXAscGFuZWw6IHBoYW5kbGUgdG8gYSBwYW5lbCBub2RlIGFzIGRlc2NyaWJlZCBieQo+ICsJ RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BhbmVsLyoKCkRvZXNuJ3QgdGhpcyBk dXBsaWNhdGUgdGhlIGluZm9ybWF0aW9uIHByb3ZpZGVkIGJ5IHRoZSBwb3J0cyA/Cgo+ICstIHJv Y2tjaGlwLGRhdGEtbWFwcGluZzogc2hvdWxkIGJlICJ2ZXNhIiBvciAiamVpZGEiLAo+ICsJVGhp cyBkZXNjcmliZXMgaG93IHRoZSBjb2xvciBiaXRzIGFyZSBsYWlkIG91dCBpbiB0aGUKPiArCXNl cmlhbGl6ZWQgTFZEUyBzaWduYWwuCj4gKy0gcm9ja2NoaXAsZGF0YS13aWR0aCA6IHNob3VsZCBi ZSA8MTg+IG9yIDwyND47Cj4gKy0gcm9ja2NoaXAsb3V0cHV0OiBzaG91bGQgYmUgInJnYiIsICJs dmRzIiBvciAiZHVhbGx2ZHMiLAo+ICsJVGhpcyBkZXNjcmliZXMgdGhlIG91dHB1dCBmYWNlLgoK SXNuJ3QgYWxsIHRoaXMgcGFuZWwtZGVwZW5kZW50ID8gQ291bGQgd2UgcXVlcnkgdGhlIGluZm9y bWF0aW9uIGZyb20gdGhlIHBhbmVsIAphdCBydW50aW1lIGluc3RlYWQgPwoKPiArLSBwb3J0czog Y29udGFpbiBhIHBvcnQgbm9kZSB3aXRoIGVuZHBvaW50IGRlZmluaXRpb25zIGFzIGRlZmluZWQg aW4KPiArCURvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRpYS92aWRlby1pbnRl cmZhY2VzLnR4dC4KPiArCj4gK0V4YW1wbGU6Cj4gKwlsdmRzOiBsdmRzQGZmOTZjMDAwIHsKPiAr CQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzI4OC1sdmRzIjsKPiArCQlyb2NrY2hpcCxncmYg PSA8JmdyZj47Cj4gKwkJcmVnID0gPDB4ZmY5NmMwMDAgMHg0MDAwPjsKPiArCQljbG9ja3MgPSA8 JmNydSBQQ0xLX0xWRFNfUEhZPjsKPiArCQljbG9jay1uYW1lcyA9ICJwY2xrX2x2ZHMiOwo+ICsJ CWF2ZGQxdjAtc3VwcGx5ID0gPCZ2ZGQxMF9sY2Q+Owo+ICsJCWF2ZGQxdjgtc3VwcGx5ID0gPCZ2 Y2MxOF9sY2Q+Owo+ICsJCWF2ZGQzdjMtc3VwcGx5ID0gPCZ2Y2NhXzMzPjsKPiArCQlyb2NrY2hp cCxwYW5lbCA9IDwmcGFuZWw+Owo+ICsJCXJvY2tjaGlwLGRhdGEtbWFwcGluZyA9ICJqZWlkYSI7 Cj4gKwkJcm9ja2NoaXAsZGF0YS13aWR0aCA9IDwyND47Cj4gKwkJcm9ja2NoaXAsb3V0cHV0ID0g InJnYiI7Cj4gKwkJcG9ydHMgewo+ICsJCQlsdmRzX2luOiBwb3J0IHsKPiArCQkJCSNhZGRyZXNz LWNlbGxzID0gPDE+Owo+ICsJCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gKwkJCQlsdmRzX2luX3Zv cGI6IGVuZHBvaW50QDAgewo+ICsJCQkJCXJlZyA9IDwwPjsKPiArCQkJCQlyZW1vdGUtZW5kcG9p bnQgPSA8JnZvcGJfb3V0X2x2ZHM+Owo+ICsJCQkJfTsKPiArCQkJCWx2ZHNfaW5fdm9wbDogZW5k cG9pbnRAMSB7Cj4gKwkJCQkJcmVnID0gPDE+Owo+ICsJCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwm dm9wbF9vdXRfbHZkcz47Cj4gKwkJCQl9Owo+ICsJCQl9Owo+ICsJCX07Cj4gKwl9OwoKLS0gClJl Z2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=