Re: [12/12] acpi: set fake hid

[Zhang Rui <rui.zhang@intel.com>]

On Mon, 2006-09-25 at 12:40 +0300, Mika Penttilä wrote:
> Zhang Rui wrote:
> > On Fri, 2006-09-22 at 14:59 +0300, Mika Penttilä wrote: 
> >   
> >> +static int acpi_pci_bridge_match(struct acpi_device *device)
> >> +{
> >> +       acpi_status status;
> >> +       acpi_handle handle;
> >> +
> >> +       /* pci bridge has _PRT but isn't PNP0A03 */
> >> +       status = acpi_get_handle(device->handle, METHOD_NAME__PRT, &handle);
> >> +       if (ACPI_FAILURE(status))
> >> +               return -ENODEV;
> >> +       if (!acpi_match_ids(device, "PNP0A03"))
> >> +               return -ENODEV;
acpi_pci_bridge_match will return 0, if we found a
pci-pci bridge. Because it has a PRT table and its
HID is _NOT_ "PNP0A03".
> >> +       return 0;
> >> +}
> >> +
> >>
> >>
> >> You seem to handle pci-pci bridge here incorrectly (returns -ENODEV from match to PNP0A03)
> >>
> >>     
> > Is there any pci-pci bridge that has a _HID of "PNP0A03"?
> >
> > thanks,
> > --Rui
> >
> >   
> Don't know, but isn't the purpose here for acpi_pci_bridge_match() to 
> match pci-pci bridges also? They won't just because they aren't PNP0A03.
> 
> --Mika
According to the ACPI spec, only ACPI PCI Root Bridge has a _HID of
"PNP0A03".


-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html