From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjan@infradead.org>,
Dave Jones <davej@redhat.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/2] serio: lockdep annotation for ps2dev->cmd_mutex and serio->lock
Date: Tue, 26 Sep 2006 15:36:38 +0200 [thread overview]
Message-ID: <1159277799.5038.22.camel@lappy> (raw)
In-Reply-To: <Pine.LNX.4.64.0609261520280.3938@twin.jikos.cz>
On Tue, 2006-09-26 at 15:21 +0200, Jiri Kosina wrote:
> the lockdep part of the patch (1/2) is OK. The second part, specifically
> the libps2.c changes, are not complete - the originally (wrongly)
> introduced mutex_lock_nested() has to be changed back to mutex_lock(),
> otherwise we will get spurious warning from lockdep about ps2_mutex_key.
Ah, missed that that part was actually in the tree ;-)
> Below is the fixed version of the patch. I confirm that this (together
> with Peter's original changes in lockdep, already acked by Ingo) fixes the
> synpatics passthrough port lockdep warnings.
>
> So, as long as you, Dmitry, seem to be convenient with this approach,
> please apply. Thanks.
>
> Signed-off-by: Jiri Kosina <jikos@jikos.cz>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Thanks for testing
next prev parent reply other threads:[~2006-09-26 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 11:31 [PATCH 0/2] serio lockdep annotation Peter Zijlstra
2006-09-26 11:31 ` [PATCH 1/2] lockdep: lockdep_set_class_and_subclass Peter Zijlstra
2006-09-26 11:54 ` Ingo Molnar
2006-09-26 12:20 ` Dmitry Torokhov
2006-09-26 11:31 ` [PATCH 2/2] serio: lockdep annotation for ps2dev->cmd_mutex and serio->lock Peter Zijlstra
2006-09-26 13:21 ` Jiri Kosina
2006-09-26 13:36 ` Peter Zijlstra [this message]
2006-09-26 13:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159277799.5038.22.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.