From: Nathan Scott <nscott@aconex.com>
To: David Chinner <dgc@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: Review: clean up inode i_flags handling
Date: Wed, 04 Oct 2006 08:26:13 +1000 [thread overview]
Message-ID: <1159914373.32536.9.camel@edge> (raw)
In-Reply-To: <20061003051325.GR4695059@melbourne.sgi.com>
On Tue, 2006-10-03 at 15:13 +1000, David Chinner wrote:
>
This part seems like overkill, I'd just do that inline like the clear
variant, since its just one instruction ...
+static inline void
+__xfs_iflags_set(xfs_inode_t *ip, unsigned short flags)
+{
+ ip->i_flags |= flags;
+}
Oh, ditto for the test inline func, I guess.
cheers.
--
Nathan
next prev parent reply other threads:[~2006-10-03 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 5:13 Review: clean up inode i_flags handling David Chinner
2006-10-03 22:26 ` Nathan Scott [this message]
2006-10-03 23:58 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159914373.32536.9.camel@edge \
--to=nscott@aconex.com \
--cc=dgc@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.