From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Amol Lad <amol@verismonetworks.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 4/5] ioremap balanced with iounmap for drivers/char/rio/rio_linux.c
Date: Fri, 06 Oct 2006 12:21:55 +0100 [thread overview]
Message-ID: <1160133715.1607.64.camel@localhost.localdomain> (raw)
In-Reply-To: <1160110628.19143.89.camel@amol.verismonetworks.com>
Ar Gwe, 2006-10-06 am 10:27 +0530, ysgrifennodd Amol Lad:
> Signed-off-by: Amol Lad <amol@verismonetworks.com>
> ---
> rio_linux.c | 3 +++
> 1 files changed, 3 insertions(+)
> ---
> diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/char/rio/rio_linux.c linux-2.6.19-rc1/drivers/char/rio/rio_linux.c
> --- linux-2.6.19-rc1-orig/drivers/char/rio/rio_linux.c 2006-10-05 14:00:43.000000000 +0530
> +++ linux-2.6.19-rc1/drivers/char/rio/rio_linux.c 2006-10-05 14:50:00.000000000 +0530
> @@ -1181,6 +1181,9 @@ static void __exit rio_exit(void)
> }
> /* It is safe/allowed to del_timer a non-active timer */
> del_timer(&hp->timer);
> +
> + if (hp->Caddr)
> + iounmap(hp->Caddr);
> }
I don't think this is sufficient because it may be unmapped earlier on
error but hp->Caddr is not then cleared .
next prev parent reply other threads:[~2006-10-06 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 4:57 [PATCH 4/5] ioremap balanced with iounmap for drivers/char/rio/rio_linux.c Amol Lad
2006-10-06 11:21 ` Alan Cox [this message]
2006-10-06 11:21 ` Amol Lad
2006-10-06 14:03 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160133715.1607.64.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=amol@verismonetworks.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.