From: Thomas Monjalon <thomas@monjalon.net>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
jerinj@marvell.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/2] bitmap: modify bitmap not empty API for 128B cacheline
Date: Sun, 17 Jan 2021 22:48:52 +0100 [thread overview]
Message-ID: <11602414.S2x50zxl5J@thomas> (raw)
In-Reply-To: <20210105085729.2814-2-ndabilpuram@marvell.com>
05/01/2021 09:57, Nithin Dabilpuram:
> Currently bitmap line not empty check API assumes cache line
> of 64B and only checks 8 slabs. Since in 128B cacheline, we
> have 16 slabs per cacheline, rte_bitmap_clear() will mark
> complete line as empty as soon as 8 slabs are empty thereby
> breaking bitmap scan functionality. Fix it by defining new
> __rte_bitmap_line_not_empty() for 128B cacheline platform.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
>
> v2:
> - Fix issue with commit message and add acked-by from Cristian.
It seems you don't want to consider this patch as a fix,
so no backport request.
Applied with title "bitmap: support 128-byte cacheline in empty check", thanks.
prev parent reply other threads:[~2021-01-17 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 10:28 [dpdk-dev] [PATCH 1/2] test/bitmap: add test case to scan after half cline is cleared Nithin Dabilpuram
2020-12-14 10:28 ` [dpdk-dev] [PATCH 2/2] bitmap: fix bitmap not empty API for 128B cacheline Nithin Dabilpuram
2021-01-04 11:09 ` Dumitrescu, Cristian
2021-01-05 8:57 ` [dpdk-dev] [PATCH v2 1/2] test/bitmap: test scan after half cline is cleared Nithin Dabilpuram
2021-01-05 8:57 ` [dpdk-dev] [PATCH v2 2/2] bitmap: modify bitmap not empty API for 128B cacheline Nithin Dabilpuram
2021-01-17 21:48 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11602414.S2x50zxl5J@thomas \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.