From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965081AbWJJI0O (ORCPT ); Tue, 10 Oct 2006 04:26:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965100AbWJJI0O (ORCPT ); Tue, 10 Oct 2006 04:26:14 -0400 Received: from gate.crashing.org ([63.228.1.57]:20691 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S965081AbWJJI0N (ORCPT ); Tue, 10 Oct 2006 04:26:13 -0400 Subject: Re: [patch 3/3] mm: fault handler to replace nopage and populate From: Benjamin Herrenschmidt To: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= Cc: Nick Piggin , Andrew Morton , Linux Memory Management , Linux Kernel In-Reply-To: <452B398C.4030507@tungstengraphics.com> References: <20061009110007.GA3592@wotan.suse.de> <1160392214.10229.19.camel@localhost.localdomain> <20061009111906.GA26824@wotan.suse.de> <1160393579.10229.24.camel@localhost.localdomain> <20061009114527.GB26824@wotan.suse.de> <1160394571.10229.27.camel@localhost.localdomain> <20061009115836.GC26824@wotan.suse.de> <1160395671.10229.35.camel@localhost.localdomain> <20061009121417.GA3785@wotan.suse.de> <452A50C2.9050409@tungstengraphics.com> <20061009135254.GA19784@wotan.suse.de> <1160427036.7752.13.camel@localhost.localdomain> <452B398C.4030507@tungstengraphics.com> Content-Type: text/plain Date: Tue, 10 Oct 2006 17:55:31 +1000 Message-Id: <1160466932.6177.0.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > Still, even with NOPAGE_REFAULT or the equivalent with the new fault() code, > in the case we need to take this route, (and it looks like we won't have > to), > I guess we still need to restart from find_vma() in the fault()/nopage() > handler to make sure the VMA is still present. The object mutex need to > be dropped as well to avoid deadlocks. Sounds complicated. But as we said, it should be enough to do the flag change with the object mutex held as long as it's after unmap_mapped_ranges() Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [patch 3/3] mm: fault handler to replace nopage and populate From: Benjamin Herrenschmidt In-Reply-To: <452B398C.4030507@tungstengraphics.com> References: <20061009110007.GA3592@wotan.suse.de> <1160392214.10229.19.camel@localhost.localdomain> <20061009111906.GA26824@wotan.suse.de> <1160393579.10229.24.camel@localhost.localdomain> <20061009114527.GB26824@wotan.suse.de> <1160394571.10229.27.camel@localhost.localdomain> <20061009115836.GC26824@wotan.suse.de> <1160395671.10229.35.camel@localhost.localdomain> <20061009121417.GA3785@wotan.suse.de> <452A50C2.9050409@tungstengraphics.com> <20061009135254.GA19784@wotan.suse.de> <1160427036.7752.13.camel@localhost.localdomain> <452B398C.4030507@tungstengraphics.com> Content-Type: text/plain Date: Tue, 10 Oct 2006 17:55:31 +1000 Message-Id: <1160466932.6177.0.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= Cc: Nick Piggin , Andrew Morton , Linux Memory Management , Linux Kernel List-ID: > Still, even with NOPAGE_REFAULT or the equivalent with the new fault() code, > in the case we need to take this route, (and it looks like we won't have > to), > I guess we still need to restart from find_vma() in the fault()/nopage() > handler to make sure the VMA is still present. The object mutex need to > be dropped as well to avoid deadlocks. Sounds complicated. But as we said, it should be enough to do the flag change with the object mutex held as long as it's after unmap_mapped_ranges() Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org