From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/4] powerpc: consolidate feature fixup code
Date: Thu, 12 Oct 2006 20:48:40 +1000 [thread overview]
Message-ID: <1160650121.4792.140.camel@localhost.localdomain> (raw)
In-Reply-To: <1160646965.16101.4.camel@localhost.localdomain>
> > void __init setup_system(void)
> > {
> > + extern unsigned int __start___ftr_fixup, __stop___ftr_fixup;
> > + extern unsigned int __start___fw_ftr_fixup, __stop___fw_ftr_fixup;
>
>
> Every extern in a C file ... god kills a kitten! :)
Well... it's a bit special in this case.. just a reference to a section,
I'd rather keep it close to the only call site...
Ben.
next prev parent reply other threads:[~2006-10-12 10:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 8:29 [PATCH 1/4] powerpc: consolidate feature fixup code Benjamin Herrenschmidt
2006-10-12 9:56 ` Michael Ellerman
2006-10-12 10:48 ` Benjamin Herrenschmidt [this message]
2006-10-12 13:56 ` Olof Johansson
2006-10-12 14:47 ` Benjamin Herrenschmidt
2006-10-12 14:56 ` Olof Johansson
2006-10-12 15:24 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160650121.4792.140.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.