From: James Bottomley <James.Bottomley@SteelEye.com>
To: malahal@us.ibm.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] AIC94XX: call tasklet_kill while unloading the module
Date: Thu, 19 Oct 2006 18:10:31 -0400 [thread overview]
Message-ID: <1161295831.11219.31.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20061019220228.GA13039@us.ibm.com>
On Thu, 2006-10-19 at 15:02 -0700, malahal@us.ibm.com wrote:
> James, I think we should stop processing the done list before
> we call asd_free_queues() which frees all pending SCB's. So
> asd_destroy_ha_caches() is too late for it. I can put it in
> asd_free_queues() if you agree.
Not really; that won't get it called correctly on the error path of
asd_pci_probe().
On the teardown path, free_irq is called long before asd_free_queues, so
nothing is going to be scheduling the tasklet, so I don't think it
matters where it's called after that.
James
prev parent reply other threads:[~2006-10-19 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 3:25 [PATCH] AIC94XX: call tasklet_kill while unloading the module malahal
2006-10-19 18:57 ` James Bottomley
2006-10-19 22:02 ` malahal
2006-10-19 22:10 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161295831.11219.31.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=malahal@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.