From: Thomas Renninger <trenn@suse.de>
To: fseidel@suse.de
Cc: linux-acpi@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: Re: [patch 0/2] acpi: driverregistration again can report ENODEV
Date: Fri, 20 Oct 2006 11:59:41 +0200 [thread overview]
Message-ID: <1161338381.32262.114.camel@queen.suse.de> (raw)
In-Reply-To: <20061020092547.519734000@neutrino.suse.de>
On Fri, 2006-10-20 at 11:25 +0200, fseidel@suse.de wrote:
> Currently acpi_bus_register_driver only reports an error
> (-ENODEV) if acpi_disabled is true,
> but many acpi drivers also depend on a negative error
> value if no driver could be attached to a device
> (as e.g. driver/acpi/asus_acpi.c).
> This patch adds this again (without changing return type
> of acpi_driver_attach for this).
Looks fine to me.
acpi_bus_register_driver must return -ENODEV when no device with
matching HID was found. E.g. battery also should currently get always
loaded even a system never has one.
driver_attach returned the amount of found devices in past, this was
changed recently (can't find the patch/mail) right now. This change
broke things and should get corrected by these patches.
Thomas
next prev parent reply other threads:[~2006-10-20 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 9:25 [patch 0/2] acpi: driverregistration again can report ENODEV fseidel
2006-10-20 9:25 ` [patch 1/2] " fseidel
2006-10-20 9:25 ` [patch 2/2] " fseidel
2006-10-20 9:59 ` Thomas Renninger [this message]
2006-10-20 16:55 ` [patch 0/2] " Bjorn Helgaas
2006-10-22 15:09 ` Thomas Renninger
2006-10-23 15:34 ` Bjorn Helgaas
2006-10-23 16:33 ` Frank Seidel
2006-10-24 9:05 ` Frank Seidel
2006-10-25 19:58 ` [patch] ACPI: asus_acpi: return -ENODEV when no device found Bjorn Helgaas
2006-10-26 9:22 ` Frank Seidel
2006-10-25 10:40 ` [patch 0/2] acpi: driverregistration again can report ENODEV Zhang Rui
2006-10-25 11:31 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161338381.32262.114.camel@queen.suse.de \
--to=trenn@suse.de \
--cc=fseidel@suse.de \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.