All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcus Fischer <marcus-fischer@web.de>
To: linux-kernel@vger.kernel.org
Cc: gregkh@suse.de
Subject: [PATCH] [4th RESEND]  Remove logic error in /Documentation/devices.txt
Date: Sun, 22 Oct 2006 13:24:53 -0400	[thread overview]
Message-ID: <1161537893.3657.4.camel@mflaptop> (raw)

Hello all,

can someone please tell me what I'm doing wrong with this commit?
I'm lacking experience, but I thought I understood the process correct.

Please send me some feedback that I can rework/modify the patch if required.


Thanks,
Marcus

PS: Please CC me, I'm not on this list.



commit 51f3fe947923f6e775031cc1d538de6cf06ec77d
Author: Marcus Fischer <linux@marcusfischer.com>
Date:   Fri Sep 29 23:50:01 2006 +0200

    I found an logic error in the following commit:
    
        author    Steven Haigh <netwiz@crc.id.au>
                  Tue, 8 Aug 2006 21:42:06 +0000 (07:42 +1000)
        committer Greg Kroah-Hartman <gregkh@suse.de>
                  Wed, 27 Sep 2006 18:58:59 +0000 (11:58 -0700)
        commit    03270634e242dd10cc8569d31a00659d25b2b8e7
        tree      8f4665eb7b17386e733fcdc7d02e87c4a1592550
        parent    8ac283ad415358f022498887811c35ac656b5222
    
Documentation/devices.txt may either say 
../adutux10 11th OntrackADU device    or 
../adutux9 10th Ontrack ADU device.

Anyway, the original one makes no sense:
   
+ 67 = /dev/usb/adutux0 1st Ontrak ADU device
+ ...
+ 76 = /dev/usb/adutux10 10th Ontrak ADU device

This patch removes the logic error.

However, I saw that MAX_DEVICES is 16.
Thus, shouldn't this docu then say:
"81 = /dev/usb/adutux15 16th Ontrack ADU device" ?

Best,
Marcus



Signed-off-by: Marcus Fischer <linux@marcusfischer.com>
---

diff --git a/Documentation/devices.txt b/Documentation/devices.txt
index addc67b..37efae8 100644
--- a/Documentation/devices.txt
+++ b/Documentation/devices.txt
@@ -2545,7 +2545,7 @@ Your cooperation is appreciated.
66 = /dev/usb/cpad0 Synaptics cPad (mouse/LCD)
67 = /dev/usb/adutux0 1st Ontrak ADU device
    ...
- 76 = /dev/usb/adutux10 10th Ontrak ADU device
+ 76 = /dev/usb/adutux9 10th Ontrak ADU device
96 = /dev/usb/hiddev0 1st USB HID device
    ...
111 = /dev/usb/hiddev15 16th USB HID device




             reply	other threads:[~2006-10-22 11:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-22 17:24 Marcus Fischer [this message]
2006-10-22 12:32 ` [PATCH] [4th RESEND] Remove logic error in /Documentation/devices.txt Oleg Verych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1161537893.3657.4.camel@mflaptop \
    --to=marcus-fischer@web.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.