diff for duplicates of <1161627784.5182.151.camel@localhost.localdomain> diff --git a/a/1.txt b/N1/1.txt index 660c078..982650a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -85,7 +85,7 @@ On Mon, 2006-10-23 at 13:54 -0400, Neil Horman wrote: > > /* Get max numbered node, calculate slots needed */ > @@ -709,16 +710,18 @@ static int __init mmtimer_init(void) -> if (timers = NULL) { +> if (timers == NULL) { > printk(KERN_ERR "%s: failed to allocate memory for device\n", > MMTIMER_NAME); > - return -1; @@ -97,7 +97,7 @@ On Mon, 2006-10-23 at 13:54 -0400, Neil Horman wrote: > /* Allocate mmtimer_t's for each online node */ > for_each_online_node(node) { > timers[node] = kmalloc_node(sizeof(mmtimer_t)*NUM_COMPARATORS, GFP_KERNEL, node); -> if (timers[node] = NULL) { +> if (timers[node] == NULL) { > printk(KERN_ERR "%s: failed to allocate memory for device\n", > MMTIMER_NAME); > - return -1; @@ -201,8 +201,3 @@ On Mon, 2006-10-23 at 13:54 -0400, Neil Horman wrote: > > error = misc_register(&ctl_device); > if (error) - -_______________________________________________ -Kernel-janitors mailing list -Kernel-janitors@lists.osdl.org -https://lists.osdl.org/mailman/listinfo/kernel-janitors diff --git a/a/content_digest b/N1/content_digest index e298b79..05d4271 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\01161625164.21701.18.camel@localhost.localdomain\0" "ref\020061023175427.GB23714@hmsreliant.homelinux.net\0" "From\0Kylene Jo Hall <kjhall@us.ibm.com>\0" - "Subject\0Re: [KJ] [PATCH] Correct misc_register return code handling\0" - "Date\0Mon, 23 Oct 2006 18:23:04 +0000\0" + "Subject\0Re: [KJ][PATCH] Correct misc_register return code handling in several drivers\0" + "Date\0Mon, 23 Oct 2006 11:23:04 -0700\0" "To\0Neil Horman <nhorman@tuxdriver.com>\0" "Cc\0Alan Cox <alan@lxorguk.ukuu.org.uk>" kernel-janitors@lists.osdl.org @@ -100,7 +100,7 @@ "> \n" "> \t/* Get max numbered node, calculate slots needed */\n" "> @@ -709,16 +710,18 @@ static int __init mmtimer_init(void)\n" - "> \tif (timers = NULL) {\n" + "> \tif (timers == NULL) {\n" "> \t\tprintk(KERN_ERR \"%s: failed to allocate memory for device\\n\",\n" "> \t\t\t\tMMTIMER_NAME);\n" "> -\t\treturn -1;\n" @@ -112,7 +112,7 @@ "> \t/* Allocate mmtimer_t's for each online node */\n" "> \tfor_each_online_node(node) {\n" "> \t\ttimers[node] = kmalloc_node(sizeof(mmtimer_t)*NUM_COMPARATORS, GFP_KERNEL, node);\n" - "> \t\tif (timers[node] = NULL) {\n" + "> \t\tif (timers[node] == NULL) {\n" "> \t\t\tprintk(KERN_ERR \"%s: failed to allocate memory for device\\n\",\n" "> \t\t\t\tMMTIMER_NAME);\n" "> -\t\t\treturn -1;\n" @@ -215,11 +215,6 @@ "> +\tINIT_LIST_HEAD(&ctl_device.list);\n" "> \n" "> \terror = misc_register(&ctl_device);\n" - "> \tif (error)\n" - "\n" - "_______________________________________________\n" - "Kernel-janitors mailing list\n" - "Kernel-janitors@lists.osdl.org\n" - https://lists.osdl.org/mailman/listinfo/kernel-janitors + "> \tif (error)" -b784dd526ff6ec9c384a863b8af1755ea5e8315bfed3537b20b3e6d1938f4394 +c441e6c728c595d52aef858cc78bc4df3deab0198d4dcb06c0b61bae6beb8a06
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.