All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <1161660875.10524.535.camel@localhost.localdomain>

diff --git a/a/1.txt b/N1/1.txt
index 15dc1da..7bbe934 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -59,7 +59,7 @@ all misc devices ? Can't it be statically initialized instead ?
 >  
 >  	/* Get max numbered node, calculate slots needed */
 > @@ -709,16 +710,18 @@ static int __init mmtimer_init(void)
->  	if (timers = NULL) {
+>  	if (timers == NULL) {
 >  		printk(KERN_ERR "%s: failed to allocate memory for device\n",
 >  				MMTIMER_NAME);
 > -		return -1;
@@ -71,7 +71,7 @@ all misc devices ? Can't it be statically initialized instead ?
 >  	/* Allocate mmtimer_t's for each online node */
 >  	for_each_online_node(node) {
 >  		timers[node] = kmalloc_node(sizeof(mmtimer_t)*NUM_COMPARATORS, GFP_KERNEL, node);
->  		if (timers[node] = NULL) {
+>  		if (timers[node] == NULL) {
 >  			printk(KERN_ERR "%s: failed to allocate memory for device\n",
 >  				MMTIMER_NAME);
 > -			return -1;
@@ -176,8 +176,3 @@ all misc devices ? Can't it be statically initialized instead ?
 >  
 >  	error = misc_register(&ctl_device);
 >  	if (error)
-
-_______________________________________________
-Kernel-janitors mailing list
-Kernel-janitors@lists.osdl.org
-https://lists.osdl.org/mailman/listinfo/kernel-janitors
diff --git a/a/content_digest b/N1/content_digest
index 747e821..b60890a 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -1,7 +1,7 @@
  "ref\020061023171910.GA23714@hmsreliant.homelinux.net\0"
  "From\0Benjamin Herrenschmidt <benh@kernel.crashing.org>\0"
- "Subject\0Re: [KJ] [PATCH] Correct misc_register return code handling\0"
- "Date\0Tue, 24 Oct 2006 03:34:34 +0000\0"
+ "Subject\0Re: [KJ][PATCH] Correct misc_register return code handling in several drivers\0"
+ "Date\0Tue, 24 Oct 2006 13:34:34 +1000\0"
  "To\0Neil Horman <nhorman@tuxdriver.com>\0"
  "Cc\0kernel-janitors@lists.osdl.org"
   kjhall@us.ibm.com
@@ -71,7 +71,7 @@
  ">  \n"
  ">  \t/* Get max numbered node, calculate slots needed */\n"
  "> @@ -709,16 +710,18 @@ static int __init mmtimer_init(void)\n"
- ">  \tif (timers = NULL) {\n"
+ ">  \tif (timers == NULL) {\n"
  ">  \t\tprintk(KERN_ERR \"%s: failed to allocate memory for device\\n\",\n"
  ">  \t\t\t\tMMTIMER_NAME);\n"
  "> -\t\treturn -1;\n"
@@ -83,7 +83,7 @@
  ">  \t/* Allocate mmtimer_t's for each online node */\n"
  ">  \tfor_each_online_node(node) {\n"
  ">  \t\ttimers[node] = kmalloc_node(sizeof(mmtimer_t)*NUM_COMPARATORS, GFP_KERNEL, node);\n"
- ">  \t\tif (timers[node] = NULL) {\n"
+ ">  \t\tif (timers[node] == NULL) {\n"
  ">  \t\t\tprintk(KERN_ERR \"%s: failed to allocate memory for device\\n\",\n"
  ">  \t\t\t\tMMTIMER_NAME);\n"
  "> -\t\t\treturn -1;\n"
@@ -187,11 +187,6 @@
  "> +\tINIT_LIST_HEAD(&ctl_device.list);\n"
  ">  \n"
  ">  \terror = misc_register(&ctl_device);\n"
- ">  \tif (error)\n"
- "\n"
- "_______________________________________________\n"
- "Kernel-janitors mailing list\n"
- "Kernel-janitors@lists.osdl.org\n"
- https://lists.osdl.org/mailman/listinfo/kernel-janitors
+ ">  \tif (error)"
 
-bf68b6d92b9ca234ee800b53e7a89a8efd3a73a98d60840bf4901125218fc320
+81fe011e7ecab2894414c9f0aad9e1ed25adda09cc2bbe242fc48cd89f689e73

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.