From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
linux1394-devel@lists.sourceforge.net,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: pci_set_power_state() failure and breaking suspend
Date: Wed, 25 Oct 2006 08:40:16 +1000 [thread overview]
Message-ID: <1161729616.10524.657.camel@localhost.localdomain> (raw)
In-Reply-To: <453DFBFF.8040001@s5r6.in-berlin.de>
On Tue, 2006-10-24 at 13:41 +0200, Stefan Richter wrote:
> Benjamin Herrenschmidt wrote:
> > Well, the question is wether we want to make the whole machine suspend
> > fail because there is a 1394 chip that doesn't do PCI PM in or not...
> >
> > I can send patches "fixing" it both ways (just ignoring the result from
> > pci_set_power_state in general, or just ignoring that result on Apple
> > cells).
>
> Yes, what would be the correct way to do this? And if it the latter
> option, should that be implemented in ohci1394 or in pci_set_power_state?
>
> grep says that almost nobody checks the return code of
> pci_set_power_state. But e.g. usb/core/hcd-pci.c does...
Yes, and I think that's bogus too ...
> (Side note: The sole function that ohci1394's suspend and resume hooks
> fulfill right now in mainline is to change power consumption of the
> chip. The IEEE 1394 stack as a whole does not survive suspend + resume
> yet. A still incomplete solution is in linux1394-2.6.git.)
next prev parent reply other threads:[~2006-10-24 22:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 6:54 pci_set_power_state() failure and breaking suspend Benjamin Herrenschmidt
2006-10-24 7:40 ` Benjamin Herrenschmidt
2006-10-24 8:13 ` Stefan Richter
2006-10-24 8:13 ` Stefan Richter
2006-10-24 8:29 ` Benjamin Herrenschmidt
2006-10-24 8:29 ` Benjamin Herrenschmidt
2006-10-24 11:41 ` Stefan Richter
2006-10-24 11:41 ` Stefan Richter
2006-10-24 22:40 ` Benjamin Herrenschmidt [this message]
2006-10-25 6:40 ` Stefan Richter
2006-10-25 6:40 ` Stefan Richter
2006-10-25 6:48 ` Stefan Richter
2006-10-25 6:48 ` Stefan Richter
2006-10-25 6:51 ` Stefan Richter
2006-10-25 6:51 ` Stefan Richter
2006-10-25 7:44 ` [rfc patch linux1394-2.6.git 1/2] ieee1394: ohci1394: revert fail on error in suspend Stefan Richter
2006-10-25 7:46 ` [rfc patch linux1394-2.6.git 2/2] ieee1394: ohci1394: proper log messages in suspend and resume Stefan Richter
2006-10-24 12:00 ` pci_set_power_state() failure and breaking suspend Rafael J. Wysocki
2006-10-24 12:00 ` Rafael J. Wysocki
2006-10-24 16:09 ` Scott Wood
2006-10-24 16:09 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161729616.10524.657.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.