Re: [PATCH][RESEND] PV drivers for HVM guests

[Ian Campbell <Ian.Campbell@XenSource.com>]

On Fri, 2006-10-27 at 13:11 +0900, Doi.Tsunehisa@jp.fujitsu.com wrote:
> Takanori (he is my co-worker) checked this patch, but it occures
> compile error in linux-xen. We are investigating it.

Thanks, I'll reply to him in a moment.

> >>   BTW, I might find a issue about NET_IP_ALIGN in the compatible shim.
> >> Currentry, its value is 0, but the value should be matched a value of
> >> netback module. Thus, its value should be 2, I think.
> >> 
> >>   What do you think about the issue ?
> >
> > My thinking was that since those older kernels don't define NET_IP_ALIGN
> > and don't hardcode the number 2 anywhere they don't expect any extra
> > alignment. Therefore using 0 seems correct in terms of behaving the same
> > as native drivers do on those versions. I'm not sure I would want to
> > backport the addition of the extra padding in our drivers, the distros
> > haven't seen the need for example...
> 
> Hmm, I thought that NET_IF_ALIGN mismatch between netfront and netback
> occures a confusion of VNIF. But I might be imagining if it was used
> correctly.

I'd not heard about or seen that problem. Lets leave things as they are
and if a problem arises we'll revisit it.

> Is it used on SLES9 guest ? I don't have the environment.

Yes, I'm compile testing against SLES9sp3 (2.6.5 based) and RHEL4 update
4 (2.6.9 based) kernels. I don't have an IA64 platform to do anything
more than that.

Ian.