Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

[Johannes Berg <johannes@sipsolutions.net>]

On Sun, 2006-10-29 at 14:35 +0200, chunkeey@web.de wrote:

> +#define MAC2STR(a) (a)[0], (a)[1], (a)[2], (a)[3], (a)[4], (a)[5]: 
> +#define MACSTR "%02x: %02x:%02x:%02x:%02x:%02x"

such defines should exist already in ieee80211 headers.

> -       /* Update our wireless stats, but do not schedule to often: 
> +       /* Update our wireless stats, but do not schedule to often : 

You could have fixed to->too while at it :)

> -       range->encoding_size[0] = 5;: 
> +       range->encoding_size[0] = KEY_SIZE_WEP40;: 
>         /* 128(104) bits WEP */
> -       range->encoding_size[1] = 13;: 
> +       range->encoding_size[1] = WEP_KEY_LEN;: 
>         /* 256 bits for WPA-PSK */
> -       range->encoding_size[2] = 32;: 
> +       range->encoding_size[2] = SCM_KEY_LEN;: 

Are there no constants for these in the ieee80211 headers? These look
home-grown.

> +               attach->type = DOT11_PKT_BEACON;: 

> +               attach->type = DOT11_PKT_PROBE_RESP;: 

These also look home-grown.


> -                        "%s %s %2.2X: %2.2X:%2.2X:%2.2X:%2.2X:%2.2X %s (%2.2X)",
> +                        "%s %s %2.2X: %2.2X:%2.2X:%2.2X:%2.2X:%2.2X [%2.2x %2.2X %4.4X]",
>                          str,
>                          ((priv->iw_mode == IW_MODE_MASTER) ? "from" : "to"),
>                          a[0], a[1], a[2], a[3], a[4], a[5],

Umm...

johannes