From: Rusty Russell <rusty@rustcorp.com.au>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, drepper@redhat.com, mingo@elte.hu,
tglx@linutronix.de
Subject: Re: [patch 1/1] schedule removal of FUTEX_FD
Date: Wed, 01 Nov 2006 12:19:05 +1100 [thread overview]
Message-ID: <1162343945.14769.16.camel@localhost.localdomain> (raw)
In-Reply-To: <200610312309.k9VN9mco015260@shell0.pdx.osdl.net>
On Tue, 2006-10-31 at 15:09 -0800, akpm@osdl.org wrote:
> From: Andrew Morton <akpm@osdl.org>
>
> Apparently FUTEX_FD is unfixably racy and nothing uses it (or if it does, it
> shouldn't).
>
> Add a warning printk, give any remaining users six months to migrate off it.
This makes sense. FUTEX_FD was for the NGPT project which did userspace
threading, and hence couldn't block. It was always kind of a hack
(although unfixably racy isn't quite right, it depends on usage).
However, the existence of FUTEX_FD is what made Ingo complain that we
couldn't simply pin the futex page in memory, because now a process
could pin one page per fd. Removing it would seem to indicate that we
can return to a much simpler scheme of (1) pinning a page when someone
does futex_wait, and (2) simply comparing futexes by physical address.
Now, I realize with some dismay that simplicity is no longer a futex
feature, but it might be worth considering?
Cheers,
Rusty.
PS. I used to have a patch for "ratelim_printk()" which hashed on the
format string to reduce the chance that one message limit would clobber
other messages. I'll dig it out...
next prev parent reply other threads:[~2006-11-01 1:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 23:09 [patch 1/1] schedule removal of FUTEX_FD akpm
2006-10-31 23:27 ` Thomas Gleixner
2006-10-31 23:48 ` Alan Cox
2006-11-01 0:05 ` Thomas Gleixner
2006-11-01 0:09 ` Andrew Morton
2006-11-01 1:19 ` Rusty Russell [this message]
2006-11-01 1:23 ` Andrew Morton
2006-11-01 9:11 ` bert hubert
2006-11-01 9:18 ` Andrew Morton
2006-11-01 10:03 ` bert hubert
2006-11-01 10:19 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162343945.14769.16.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.