From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <benh@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTP id 1B43067C10
	for <linuxppc-dev@ozlabs.org>; Sun,  5 Nov 2006 17:46:52 +1100 (EST)
Subject: Re: [patch 01/16] remove inclusion of asm/processor.h for powerpc
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
In-Reply-To: <20061103084237.GA22478@localhost.localdomain>
References: <20061102125555.252338000@localhost.localdomain>
	<20061102125624.134898000@localhost.localdomain>
	<1162506020.10630.31.camel@localhost.localdomain>
	<20061103084237.GA22478@localhost.localdomain>
Content-Type: text/plain
Date: Sun, 05 Nov 2006 17:46:46 +1100
Message-Id: <1162709206.28571.211.camel@localhost.localdomain>
Mime-Version: 1.0
Cc: linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Fri, 2006-11-03 at 09:42 +0100, Sascha Hauer wrote:
> On Fri, Nov 03, 2006 at 09:20:20AM +1100, Benjamin Herrenschmidt wrote:
> > On Thu, 2006-11-02 at 13:55 +0100, s.hauer@pengutronix.de wrote:
> > > plain text document attachment
> > > (drivers-ide-pci-via82xxx-remove-ppc-ifdef.diff)
> > > Remove inclusion of asm/processor.h for powerpc. It was used for
> > > some ppc specific hook in this file, but the hook is gone
> > 
> > It's not:
> > 
> > init_hwif_via82cxxx() contains:
> > 
> > #if defined(CONFIG_PPC_CHRP) && defined(CONFIG_PPC32)
> >         if(machine_is(chrp) && _chrp_type == _CHRP_Pegasos) {
> >                 hwif->irq = hwif->channel ? 15 : 14;
> >         }
> > #endif
> > 
> > Now you can replace CONFIG_PPC_MULTIPLATFORM with CONFIG_PPC_CHRP
> > 
> 
> Oops, missed that one. Here is an updated version:
> 
> Remove inclusion of asm/processor.h for powerpc. It was used for
> some ppc specific hook in this file, but the hook is gone
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

You should update the changelog comment :)

Ben.