From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: PATCH? hrtimer_wakeup: fix a theoretical race wrt rt_mutex_slowlock()
Date: Mon, 06 Nov 2006 19:57:51 +1100 [thread overview]
Message-ID: <1162803471.28571.303.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0611051423150.25218@g5.osdl.org>
> Yes. On x86 (and x86-64) you'll never see this, because writes are always
> seen in order regardless, and in addition, the spin_lock is actually
> totally serializing anyway. On most other architectures, the spin_lock
> will serialize all the writes too, but it's not guaranteed, so in theory
> you're right. I suspect no actual architecture will do this, but hey,
> when talking memory ordering, safe is a lot better than sorry.
PowerPC doesn't serialize the writes on spin_lock, only on spin_unlock.
(That is, previous writes can "leak" into the lock, but writes done
before the unlock can't leak out of the spinlock).
Now, I've just glanced at the thread, so I don't know if that's relevant
to the problems you guys are talking about :-)
Ben.
next prev parent reply other threads:[~2006-11-06 8:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-05 19:34 PATCH? hrtimer_wakeup: fix a theoretical race wrt rt_mutex_slowlock() Oleg Nesterov
2006-11-05 22:29 ` Linus Torvalds
2006-11-05 22:53 ` Steven Rostedt
2006-11-05 23:08 ` Oleg Nesterov
2006-11-06 3:08 ` Linus Torvalds
2006-11-06 12:09 ` Oleg Nesterov
2006-11-06 12:26 ` Steven Rostedt
2006-11-05 22:53 ` Oleg Nesterov
2006-11-06 8:57 ` Benjamin Herrenschmidt [this message]
2006-11-06 12:35 ` Steven Rostedt
2006-11-06 20:53 ` Benjamin Herrenschmidt
2006-11-06 21:17 ` Steven Rostedt
2006-11-06 21:41 ` Benjamin Herrenschmidt
2006-11-06 12:31 ` Steven Rostedt
2006-11-06 14:15 ` Oleg Nesterov
2006-11-06 14:11 ` Steven Rostedt
2006-11-06 15:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162803471.28571.303.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.