All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Paul Mackerras <paulus@samba.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, benjamin@sipsolutions.net
Subject: Re: [RFC/PATCH] Stop Apple i2s DMA gracefully
Date: Mon, 06 Nov 2006 11:50:57 +0100	[thread overview]
Message-ID: <1162810257.2762.19.camel@ux156> (raw)
In-Reply-To: <17743.4433.435455.686127@cargo.ozlabs.ibm.com>

On Mon, 2006-11-06 at 21:41 +1100, Paul Mackerras wrote:

> OK, this sounds like the suspend trigger should just abort the DMA, on
> the basis that the hardware will get reset in the suspend/resume
> process and so there will be no bytes queued up to cause trouble
> later.  I'll whip up a patch.

I think we should cleanly stop the hardware in this case as well, for
suspend to disk I think it can happen that we suspend the driver and
then suspend is aborted. Not entirely sure about this though.

Btw. What happens when we abort the DMA engine, reset the command
pointer to a stop command, and start it again? Does it drain the FIFO
properly? I'm thinking it should, but ...

johannes

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  reply	other threads:[~2006-11-06 10:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-29  4:19 [RFC/PATCH] Stop Apple i2s DMA gracefully Paul Mackerras
2006-10-29  8:49 ` Johannes Berg
2006-10-29 10:47   ` Paul Mackerras
2006-10-29 12:23     ` Johannes Berg
2006-10-31 14:14 ` Takashi Iwai
2006-11-01  1:05   ` Paul Mackerras
2006-11-02  8:29 ` Johannes Berg
2006-11-02 21:54   ` Paul Mackerras
2006-11-02 22:59     ` Johannes Berg
2006-11-06 10:38       ` Takashi Iwai
2006-11-06 10:41         ` Paul Mackerras
2006-11-06 10:50           ` Johannes Berg [this message]
2006-11-28 12:03           ` Takashi Iwai
2006-11-06 10:47         ` Johannes Berg
2007-02-08 13:12 ` [PATCH] aoa i2sbus: " Johannes Berg
2007-02-08 13:12   ` Johannes Berg
2007-02-08 14:07   ` Takashi Iwai
2007-02-08 14:07     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1162810257.2762.19.camel@ux156 \
    --to=johannes@sipsolutions.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=benjamin@sipsolutions.net \
    --cc=paulus@samba.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.