From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Edi Shmueli <edi@linux.vnet.ibm.com>,
linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH 1/1] PPC32 : Huge-page support for ppc440
Date: Tue, 07 Nov 2006 13:24:47 +1100 [thread overview]
Message-ID: <1162866287.28571.392.camel@localhost.localdomain> (raw)
In-Reply-To: <1162864834.3809.21.camel@zod.rchland.ibm.com>
On Mon, 2006-11-06 at 20:00 -0600, Josh Boyer wrote:
> Hi Edi,
>
> On Mon, 2006-11-06 at 18:21 -0500, Edi Shmueli wrote:
> > From: Edi Shmueli edi@linux.vnet.ibm.com
> >
> > This patch enables applications to exploit the PPC440 TLB support for
> > huge-page mapping, to minimize TLB thrashing.
> > Applications with large memory footprint that exploit this support,
> > experience minimal TLB misses, and boost in performance.
> > NAS benchmarks performed with this patch indicate hundreds of percent of
> > improvement in performance for some application.
> > Known limitations: because each PMD covers 2MB of the process address
> > space, the minimal huge-page size supported by this patch is 2M.
> >
> > Signed-off-by: Edi Shmueli edi@linux.vnet.ibm.com
>
> Your patch is line wrapped and the whitespace has been corrupted. It's
> also against a bit older version of the kernel.
>
> Could you try to fixup these issues and resubmit? Paul's powerpc.git
> tree would probably be best to diff against.
Also, while it's great to have somebody do this work, I doubt there is
much interest in merging it for arch/ppc...
Ben.
next prev parent reply other threads:[~2006-11-07 2:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 23:21 [PATCH 1/1] PPC32 : Huge-page support for ppc440 Edi Shmueli
2006-11-07 2:00 ` Josh Boyer
2006-11-07 2:24 ` Benjamin Herrenschmidt [this message]
2006-11-07 3:26 ` Roland Dreier
2006-11-07 3:45 ` Benjamin Herrenschmidt
2006-11-07 11:52 ` Josh Boyer
2006-11-07 18:55 ` Roland Dreier
2006-11-08 3:08 ` Edi Shmueli
2006-11-07 15:47 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162866287.28571.392.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=edi@linux.vnet.ibm.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.